[7.x] [Enterprise Search] Move externalUrl helper out of React Context (#78368) #78497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stic#78368) * Add new/simpler externalUrl helper and initialize it on renderApp - This uses a simple JS obj to store the enterpriseSearchUrl reference (once on plugin init) - This is vs. a class, which needs to be instantiated and passed around - the new obj can be imported flatly at any time - I also opted to not convert this into a Kea logic file - after some deliberation I decided against it because it felt really weird as one. It's not storing "state" per se that ever needs to be updated, it's simply a one-time set obj that contains helper functions. - There's also some hope that we might eventually not need this helper after the full migration, so the simpler it is to delete the better - Uses a getter & setter to ensure that we don't accidentally mutate said obj after initialization * Update all components using get*SearchUrl helpers * Update tests for updated components - Mostly just consists of mocking externalUrl and importing that mock * Remove old ExternalUrl class/context TODO in next commit: Address kibana_header_actions * Update Workplace Search Header Actions to use new externalUrl helper NOTE: this requires a temporary workaround of initializing externalUrl.enterpriseSearch in plugin.ts rather than in renderApp, because renderApp loads *after* the header app does. I plan on fixing this in a future PR so that setHeaderActionMenu is called AFTER renderApp has done loading (to ensure all the state in headerActions we need is available).
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: