upgrade chromedriver 2.21.2 -> 2.22.1

[ppisljar]

tests involving alert or confirm boxes were failing for me with "unexpected alert box" error message.

it also happened at CI ... but cant find that log now.

[ppisljar]

jenkins, test this

[ppisljar]

@LeeDr can you reproduce this error on your end ?

[LeeDr]

Here's a link to the jenkins test failure;
https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-selenium/61/consoleFull

And a bit of that log in case it gets cleaned up;

>> PASS: chrome on any platform - settings app - index result field sort - sort by heading - name - should sort ascending (490ms)
14:17:07.040: tryForTime failure: [GET http://localhost:4444/wd/hub/session/220e6f2a10e9a3ca86a35ad97cf56482/alert_text] unknown error: cannot determine loading status
from unexpected alert open
  (Session info: chrome=51.0.2704.106)
  (Driver info: chromedriver=2.21.371461 (633e689b520b25f3e264a2ede6b74ccc23cb636a),platform=Linux 3.13.0-74-generic x86_64)
14:17:07.549: tryForTime failure: [POST http://localhost:4444/wd/hub/session/220e6f2a10e9a3ca86a35ad97cf56482/element / {"using":"css selector","value":"button.btn.btn-danger.ng-scope"}] unexpected alert open: {Alert text : Are you sure you want to remove this index pattern?}
  (Session info: chrome=51.0.2704.106)
  (Driver info: chromedriver=2.21.371461 (633e689b520b25f3e264a2ede6b74ccc23cb636a),platform=Linux 3.13.0-74-generic x86_64)
14:17:08.058: tryForTime failure: [POST http://localhost:4444/wd/hub/session/220e6f2a10e9a3ca86a35ad97cf56482/element / {"using":"css selector","value":"button.btn.btn-danger.ng-scope"}] unexpected alert open: {Alert text : Are you sure you want to remove this index pattern?}

I was able to reproduce the problem on a Ubuntu VM, but only about 1 in 5 runs of the management tests caused it. I've experimented with a couple of different changes to narrow down the problem, try to work-around it, and capture details to file an issue on Intern (or for chromedriver).
I don't have anything concrete yet...

FYI, I run the tests in a loop like this so that it stops when it fails;

# in one shell start the ui:server
npm run test:ui:server

# in another shell run just the management tests in a loop until they fail
export count=0; while ( time npm run test:ui:runner -- --appSuites=management ); do let count=count+1; echo $count; sleep 5; done

[LeeDr]

jenkins, test this

[LeeDr]

The tests passed on the last build. Test again. jenkins, test this

[LeeDr]

jenkins, test this

[LeeDr]

@ppisljar Can you confirm you've run the management (or all the functional tests) a few times locally and they pass with chromedriver 2.18.0 ?

[LeeDr]

Another test passed. Testing again.

[LeeDr]

jenkins, test this

[ppisljar]

i can confirm. i ran tests 5 times in a row and they always passed

[LeeDr]

LGTM

I tested with the downgraded chromedriver locally and tests are passing on jenkins-ci. In the last build/test on jenkins the tests passed but there was a timeout updating github;

Finished Build : #173 of Job : elastic+kibana+pull-request+multijob-selenium with status : SUCCESS
java.lang.NullPointerExceptionSetting status of 13d7db3ebef77102f9441f403cd7bcf2443acfe6 to SUCCESS with url https://kibana-ci.elastic.co/job/elastic-kibana-pull-request/277/ and message: 'Build finished. '
Using context: kibana-ci
Could not update commit status of the Pull Request on GitHub.
java.net.SocketTimeoutException: connect timed out

[ppisljar]

latest version of chromedriver seems to fix this issue ... upgrading to latest (2.22.1)

[Bargs]

I ran into the same problem during testing yesterday, and upgrading to 2.22.1 worked for me as well. LGTM

[LeeDr]

LGTM