Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design] A couple fixes for 7.10 #78801

Merged
merged 5 commits into from
Sep 30, 2020
Merged

[Design] A couple fixes for 7.10 #78801

merged 5 commits into from
Sep 30, 2020

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Sep 29, 2020 •
edited
Loading

Header

1. Fixed placement of mobile search button

image

2. Fixed search popover from scrolling away with the page

image

KQL Bar

3. Fixed responsive size of date picker

image

4. Fixed suggestion popover from overlapping the header

image

Discover

5. Fixed spacing in save popover

image

Other responsive fixes

6. Drilldowns flyout

image

7. Alerts action menu

I don't have an after, because I don't know how to setup the TLS 🤷. But this is what it was before and I just removed the responsive layout.

image

Management

8. Fix padding for bottom bar in Advanced Settings

The EuiBottomBar adds padding to the body element, but the way the Management layout is setup, this didn't actually add any affordance for the bottom bar, so I had to add a custom body class and padding via CSS.

image

Checklist

Delete any items that are not applicable to this PR.

@cchaos cchaos added v7.10.0 release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Sep 29, 2020
@cchaos cchaos marked this pull request as ready for review September 29, 2020 15:46
@cchaos cchaos requested a review from a team as a code owner September 29, 2020 15:46
@cchaos cchaos requested a review from a team September 29, 2020 15:46
@cchaos cchaos requested review from a team as code owners September 29, 2020 15:46
@cchaos cchaos requested a review from a team September 29, 2020 15:46
Dosant
Dosant approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppArch/drilldowns panel changes LGTM.
Thank you 🚀

@mdefazio
Copy link
Contributor

These are nice!

To test alerting with TLS
yarn es snapshot --ssl
yarn start --ssl

@cchaos
Copy link
Contributor Author

cchaos commented Sep 29, 2020

Sweet, thanks @mdefazio !

ryankeairns
ryankeairns approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great batch of fixes! Thanks for tracking and addressing them all.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id value diff baseline
advancedSettings 64.4KB +570.0B 63.8KB
watcher 1.0MB +14.0B 1.0MB
total +584.0B

page load bundle size

id value diff baseline
core 800.8KB +240.0B 800.6KB
data 1.3MB +34.0B 1.3MB
globalSearchBar 28.0KB +39.0B 27.9KB
savedObjects 93.2KB +8.0B 93.2KB
uiActionsEnhanced 380.4KB -22.0B 380.5KB
total +299.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cjcenizal
cjcenizal approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watcher code LGTM, didn't test locally.

ThomThomson
ThomThomson approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally in Chrome & Firefox - everything works well! LGTM

@cchaos cchaos merged commit 7c217a7 into elastic:master Sep 30, 2020
@cchaos cchaos mentioned this pull request Sep 30, 2020
Merged
cchaos added a commit to cchaos/kibana that referenced this pull request Sep 30, 2020
@cchaos
[Design] A couple fixes for 7.10 (elastic#78801)
76a0bba 
* A few header and KQL bar fixes

* More fixes (alerts, modals)

* Fixing bottom padding for advanced settings bottom bar

* One more alerts responsive fix

* Snaps
@cchaos cchaos deleted the design/7-10-fixes branch September 30, 2020 19:34
phillipb added a commit to phillipb/kibana that referenced this pull request Sep 30, 2020
@phillipb
Merge branch 'master' of github.com:elastic/kibana into override-anom…
1587918 
…aly-detection-partition-field

* 'master' of github.com:elastic/kibana: (37 commits)
  Fixes for the Ticket 78375 (elastic#79004)
  [Security] Alert Telemetry for the Security app (elastic#77200)
  [Search bar] Remove duplicate `popoverProps` (elastic#79025)
  [Security Solution][Detections] Add rule overrides for single event EQL rules (elastic#78876)
  [SECURITY_SOLUTION][ENDPOINT] Improve Endpoint Host data generator to also integrate with Ingest (elastic#74305)
  remove file accidentally checked in (elastic#79005)
  [ML] DF Analytics creation wizard: replace select input with job type cards with icons (elastic#78872)
  [Design] A couple fixes for 7.10 (elastic#78801)
  Fix KQL autocomplete value suggestions (elastic#78676)
  [Security Solution][Resolver] New mock with cursor (elastic#78863)
  Embeddables: basic documentation (elastic#78900)
  [security solution] only import beat_schema when needed (elastic#78708)
  [Reporting] API Integration tests: fix flaky tests for Spaces CSV formatting (elastic#78849)
  [Actions] Adds a "Test Connector" button on the Connectors List to make discovery of the Test tab easier (elastic#78746)
  [Discover] Fix functional time picker test permissions (elastic#78564)
  [ML] Fixing module datafeed overrides (elastic#78925)
  Adds some missing licenses to the CSV export (elastic#78719)
  [dev/cli] ensure plugins/ and all watch source dirs exist (elastic#78973)
  [Lens] Stop using scripted metric to collect telemetry (elastic#78687)
  [Lens] fix wrong message in fields accordion (elastic#78924)
  ...
cchaos added a commit that referenced this pull request Sep 30, 2020
@cchaos
[7.x] [Design] A couple fixes for 7.10 (#78801) (#79016)
6f953c0 
* [Design] A couple fixes for 7.10 (#78801)

* A few header and KQL bar fixes

* More fixes (alerts, modals)

* Fixing bottom padding for advanced settings bottom bar

* One more alerts responsive fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

@Dosant Dosant Dosant approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cchaos @mdefazio @kibanamachine @ryankeairns @cjcenizal @pgayvallet @Dosant @ThomThomson