Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y tests for user page #79199

Merged
merged 18 commits into from
Oct 5, 2020
Merged

A11y tests for user page #79199

merged 18 commits into from
Oct 5, 2020

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Oct 1, 2020

Meta issue - #51456
a11y tests for user page
Skipped tests are because of EUI issue - elastic/eui#2841

@bhavyarm bhavyarm added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Oct 1, 2020
@bhavyarm bhavyarm self-assigned this Oct 1, 2020
@bhavyarm bhavyarm mentioned this pull request Oct 1, 2020
Open
77 tasks
@bhavyarm bhavyarm marked this pull request as ready for review October 1, 2020 22:31
@bhavyarm bhavyarm requested a review from a team as a code owner October 1, 2020 22:31
@bhavyarm bhavyarm requested review from myasonik and LeeDr October 1, 2020 22:31
jportner
jportner approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security plugin changes (adding data-test-subj to two components) LGTM!

x-pack/test/accessibility/config.ts Outdated Show resolved Hide resolved
@bhavyarm
Copy link
Contributor Author

bhavyarm commented Oct 1, 2020

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Oct 2, 2020

@elasticmachine merge upstream

LeeDr
LeeDr suggested changes Oct 2, 2020
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor change to remove some unused page objects

x-pack/test/accessibility/apps/users.ts Outdated Show resolved Hide resolved
LeeDr
LeeDr approved these changes Oct 2, 2020
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code review and Jenkins results only

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Oct 2, 2020

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Oct 5, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
alerts - 26 +26
apm - 1276 +1276
beatsManagement - 302 +302
canvas - 1132 +1132
cloud - 6 +6
crossClusterReplication - 159 +159
dashboardEnhanced - 26 +26
dashboardMode - 4 +4
dataEnhanced - 17 +17
discoverEnhanced - 11 +11
embeddableEnhanced - 11 +11
enterpriseSearch - 250 +250
features - 11 +11
fileUpload - 21 +21
globalSearch - 23 +23
globalSearchBar - 13 +13
globalSearchProviders - 8 +8
graph - 169 +169
grokdebugger - 75 +75
indexLifecycleManagement - 206 +206
indexManagement - 509 +509
infra - 1147 +1147
ingestManager - 544 +544
ingestPipelines - 493 +493
lens - 563 +563
licenseManagement - 145 +145
licensing - 12 +12
lists - 128 +128
logstash - 190 +190
maps - 618 +618
mapsLegacyLicensing - 4 +4
ml - 1222 +1222
monitoring - 635 +635
observability - 96 +96
painlessLab - 40 +40
remoteClusters - 141 +141
reporting - 45 +45
rollup - 179 +179
searchprofiler - 87 +87
security - 458 +458
securitySolution - 1998 +1998
snapshotRestore - 168 +168
spaces - 237 +237
transform - 335 +335
triggers_actions_ui - 274 +274
uiActionsEnhanced - 134 +134
upgradeAssistant - 117 +117
uptime - 655 +655
urlDrilldown - 8 +8
watcher - 237 +237
total +15165

async chunks size

id before after diff
apm - 4.2MB ⚠️ +4.2MB
beatsManagement - 683.5KB ⚠️ +683.5KB
canvas - 1.5MB ⚠️ +1.5MB
crossClusterReplication - 456.5KB ⚠️ +456.5KB
enterpriseSearch - 428.6KB ⚠️ +428.6KB
fileUpload - 574.9KB ⚠️ +574.9KB
graph - 1.3MB ⚠️ +1.3MB
grokdebugger - 568.8KB ⚠️ +568.8KB
indexLifecycleManagement - 231.7KB ⚠️ +231.7KB
indexManagement - 1.6MB ⚠️ +1.6MB
infra - 3.8MB ⚠️ +3.8MB
ingestManager - 1.1MB ⚠️ +1.1MB
ingestPipelines - 812.9KB ⚠️ +812.9KB
lens - 1.0MB ⚠️ +1.0MB
licenseManagement - 167.5KB +167.5KB
logstash - 213.4KB ⚠️ +213.4KB
maps - 3.2MB ⚠️ +3.2MB
ml - 10.6MB ⚠️ +10.6MB
monitoring - 1.2MB ⚠️ +1.2MB
observability - 163.2KB +163.2KB
painlessLab - 38.7KB +38.7KB
remoteClusters - 227.8KB ⚠️ +227.8KB
rollup - 323.3KB ⚠️ +323.3KB
searchprofiler - 705.1KB ⚠️ +705.1KB
security - 1.0MB ⚠️ +1.0MB
securitySolution - 10.3MB ⚠️ +10.3MB
snapshotRestore - 622.6KB ⚠️ +622.6KB
spaces - 45.5KB +45.5KB
transform - 1.2MB ⚠️ +1.2MB
triggers_actions_ui - 1.5MB ⚠️ +1.5MB
upgradeAssistant - 179.8KB +179.8KB
uptime - 1.7MB ⚠️ +1.7MB
watcher - 1.0MB ⚠️ +1.0MB
total ⚠️ +52.4MB

distributable file count

id before after diff
default - 47087 +47087

miscellaneous assets size

id before after diff
apm - 49.0KB +49.0KB
enterpriseSearch - 834.9KB ⚠️ +834.9KB
maps - 978.6KB ⚠️ +978.6KB
securitySolution - 326.0KB ⚠️ +326.0KB
triggers_actions_ui - 27.7KB +27.7KB
total ⚠️ +2.2MB

page load bundle size

id before after diff
alerts - 89.8KB +89.8KB
apm - 44.3KB +44.3KB
beatsManagement - 169.1KB +169.1KB
canvas - 1.0MB ⚠️ +1.0MB
cloud - 5.9KB +5.9KB
crossClusterReplication - 49.2KB +49.2KB
dashboardEnhanced - 43.1KB +43.1KB
dashboardMode - 7.5KB +7.5KB
dataEnhanced - 34.3KB +34.3KB
discoverEnhanced - 29.2KB +29.2KB
embeddableEnhanced - 25.5KB +25.5KB
enterpriseSearch - 20.0KB +20.0KB
features - 15.8KB +15.8KB
fileUpload - 9.5KB +9.5KB
globalSearch - 27.9KB +27.9KB
globalSearchBar - 29.0KB +29.0KB
globalSearchProviders - 10.3KB +10.3KB
graph - 15.8KB +15.8KB
grokdebugger - 11.5KB +11.5KB
indexLifecycleManagement - 89.9KB +89.9KB
indexManagement - 122.8KB +122.8KB
infra - 178.6KB +178.6KB
ingestManager - 511.7KB ⚠️ +511.7KB
ingestPipelines - 42.0KB +42.0KB
lens - 76.0KB +76.0KB
licenseManagement - 26.2KB +26.2KB
licensing - 23.1KB +23.1KB
lists - 164.7KB +164.7KB
logstash - 37.6KB +37.6KB
maps - 164.4KB +164.4KB
mapsLegacyLicensing - 5.1KB +5.1KB
ml - 58.5KB +58.5KB
monitoring - 222.7KB ⚠️ +222.7KB
observability - 52.4KB +52.4KB
painlessLab - 160.9KB +160.9KB
remoteClusters - 35.5KB +35.5KB
reporting - 164.5KB +164.5KB
rollup - 80.3KB +80.3KB
searchprofiler - 50.9KB +50.9KB
security - 163.3KB +163.3KB
securitySolution - 587.1KB ⚠️ +587.1KB
snapshotRestore - 62.5KB +62.5KB
spaces - 364.2KB ⚠️ +364.2KB
transform - 25.4KB +25.4KB
triggers_actions_ui - 148.0KB +148.0KB
uiActionsEnhanced - 320.7KB ⚠️ +320.7KB
upgradeAssistant - 64.7KB +64.7KB
uptime - 25.2KB +25.2KB
urlDrilldown - 18.7KB +18.7KB
watcher - 27.9KB +27.9KB
total ⚠️ +5.6MB

Saved Objects .kibana field count

id before after diff
_data_stream_timestamp - 1 +1
action - 5 +5
action_task_params - 3 +3
alert - 30 +30
apm-indices - 8 +8
application_usage_daily - 2 +2
canvas-element - 8 +8
canvas-workpad - 5 +5
canvas-workpad-template - 8 +8
cases - 32 +32
cases-comments - 17 +17
cases-configure - 14 +14
cases-user-actions - 10 +10
config - 2 +2
dashboard - 17 +17
endpoint:user-artifact - 10 +10
endpoint:user-artifact-manifest - 5 +5
epm-packages - 14 +14
exception-list - 39 +39
exception-list-agnostic - 39 +39
file-upload-telemetry - 2 +2
fleet-agent-actions - 9 +9
fleet-agent-events - 11 +11
fleet-agents - 25 +25
fleet-enrollment-api-keys - 10 +10
graph-workspace - 9 +9
index-pattern - 3 +3
ingest_manager_settings - 6 +6
ingest-agent-policies - 11 +11
ingest-outputs - 10 +10
ingest-package-policies - 35 +35
kql-telemetry - 3 +3
lens - 7 +7
lens-ui-telemetry - 5 +5
map - 7 +7
ml-telemetry - 3 +3
monitoring-telemetry - 2 +2
namespace - 1 +1
namespaces - 1 +1
originId - 1 +1
query - 6 +6
references - 4 +4
sample-data-telemetry - 3 +3
search - 9 +9
siem-detection-engine-rule-actions - 8 +8
siem-detection-engine-rule-status - 12 +12
siem-ui-timeline - 90 +90
siem-ui-timeline-note - 8 +8
siem-ui-timeline-pinned-event - 7 +7
space - 9 +9
telemetry - 9 +9
timelion-sheet - 13 +13
tsvb-validation-telemetry - 2 +2
type - 1 +1
ui-metric - 2 +2
updated_at - 1 +1
upgrade-assistant-reindex-operation - 18 +18
upgrade-assistant-telemetry - 13 +13
url - 6 +6
visualization - 9 +9
total +660

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bhavyarm bhavyarm merged commit 14e58fb into elastic:master Oct 5, 2020
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 5, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-pipeli…
7f86432 
…nes/fix-description-field

* 'master' of github.com:elastic/kibana:
  A11y tests for user page (elastic#79199)
  [Ingest Pipelines] Processors editor a11y focus states (elastic#79122)
  [Ingest pipelines] Clean up component integration tests (elastic#78838)
  Drilldowns in examples (elastic#75640)
  Storybook and Jest cleanup (elastic#79305)
  adds EQL sequence rule test (elastic#79287)
  PR template a11y checklist item improvement (elastic#79243)
  [Security Solution] Adding tests for dns pipeline in the endpoint package (elastic#79177)
  [ML] Only adjust the bounds of SMV if annotations are visible (elastic#79210)
  global search to ts refs (elastic#79446)
  [Index management] Update TemplateDeserialized interface (elastic#78913)
  [Telemetry] server fetcher check all collectors ready before sending (elastic#79398)
  [Mappings editor] Fix app crash when selecting "other" field type (elastic#79434)
  [`/api/stats`] Add documentation + small improvement (elastic#79330)
  [Discover] "View surrounding documents" encodes spaces in filters (elastic#79283)
  [Lens] refactor DimensionContainer and fix flyout bug (elastic#79277)

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/pipeline_processors_editor_item/inline_text_input.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processors_tree/components/private_tree.tsx
@bhavyarm bhavyarm mentioned this pull request Oct 5, 2020
Merged
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Oct 5, 2020
@bhavyarm
A11y tests for user page (elastic#79199)
5826e48
bhavyarm added a commit that referenced this pull request Oct 5, 2020
@bhavyarm
A11y tests for user page (#79199) (#79507)
bd85df9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeDr LeeDr LeeDr approved these changes

@jportner jportner jportner approved these changes

@myasonik myasonik myasonik approved these changes

Assignees

@bhavyarm bhavyarm

Labels
Feature:Users/Roles/API Keys release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bhavyarm @kibanamachine @myasonik @jportner @LeeDr @elasticmachine