Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[babel/register] remove from build (take 2) #79379

Merged
merged 4 commits into from
Oct 2, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Oct 2, 2020

Resubmission of #79176

The issue with #79176 was that the cluster manager was not updated to start the dev-specific CLI, which lived at scripts/kibana. That CLI has now been moved to src/cli/dev and the distributable CLI from src/cli/index has been moved to src/cli/dist to make the distinction more clear.

Original description:

Fixes #78168

Removes babel/register from production builds of Kibana, requiring that all code loaded by Kibana runs without transformations in node.js. This has been the case for our code for a while, but is a new restriction for 3rd party plugins, which is why we want to get it in for 7.10 along with the rest of the biggest changes to the plugin system.

Dev docs

Kibana plugins can no longer rely on their server code being automatically transpiled with Babel. The @kbn/plugin-helpers provide a build task that will transform your plugin's server code to plain JS via Babel, but plugin authors can use any tool they like to accomplish the same result.

@spalger spalger added Team:Operations Team label for Operations Team release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 v7.10.0 labels Oct 2, 2020
@spalger spalger requested a review from a team as a code owner October 2, 2020 21:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested it locally. I haven't caught the problem in the original review because I was relying on the CI and blindly forget about the development use case.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
enterpriseSearch 430.1KB 430.2KB +31.0B

distributable file count

id before after diff
default 45846 43965 -1881
oss 26537 24624 -1913

page load bundle size

id before after diff
upgradeAssistant 64.8KB 64.9KB +31.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit dc0bccf into elastic:master Oct 2, 2020
@spalger spalger deleted the remove/babel-register-production branch October 2, 2020 23:30
spalger pushed a commit to spalger/kibana that referenced this pull request Oct 2, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	package.json
spalger pushed a commit that referenced this pull request Oct 3, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	package.json

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 5, 2020
* master: (128 commits)
  add core-js production dependency (elastic#79395)
  Add support for sharing saved objects to all spaces (elastic#76132)
  [Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (elastic#79038)
  load js-yaml lazily (elastic#79092)
  skip flaky suite (elastic#77278)
  Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (elastic#79341)
  [Security Solution] Untitled Timeline created when first action is to add note (elastic#78988)
  [Security Solutions][Detection Engine] Updates the edit rules page to:wq! only have what is selected for editing (elastic#79233)
  Cleanup yarn.lock from duplicates (elastic#66617)
  [kbn/optimizer] implement more efficient auto transpilation for node (elastic#79052)
  [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (elastic#79291)
  [core/server/plugins] don't run discovery in dev server parent process (take 2) (elastic#79358)
  [babel/register] remove from build (take 2) (elastic#79379)
  [Security Solution] Changes rules table tag display (elastic#77102)
  define integrationTestRoot in config file and use to define screensho… (elastic#79247)
  Revert "[babel/register] remove from build (elastic#79176)"
  skip flaky suite (elastic#75241)
  [Uptime] Synthetics UI (elastic#77960)
  [Security Solution] [Detections] Only display actions options if user has "read" privileges (elastic#78812)
  [babel/register] remove from build (elastic#79176)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 5, 2020
* master: (288 commits)
  add core-js production dependency (elastic#79395)
  Add support for sharing saved objects to all spaces (elastic#76132)
  [Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (elastic#79038)
  load js-yaml lazily (elastic#79092)
  skip flaky suite (elastic#77278)
  Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (elastic#79341)
  [Security Solution] Untitled Timeline created when first action is to add note (elastic#78988)
  [Security Solutions][Detection Engine] Updates the edit rules page to only have what is selected for editing (elastic#79233)
  Cleanup yarn.lock from duplicates (elastic#66617)
  [kbn/optimizer] implement more efficient auto transpilation for node (elastic#79052)
  [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (elastic#79291)
  [core/server/plugins] don't run discovery in dev server parent process (take 2) (elastic#79358)
  [babel/register] remove from build (take 2) (elastic#79379)
  [Security Solution] Changes rules table tag display (elastic#77102)
  define integrationTestRoot in config file and use to define screensho… (elastic#79247)
  Revert "[babel/register] remove from build (elastic#79176)"
  skip flaky suite (elastic#75241)
  [Uptime] Synthetics UI (elastic#77960)
  [Security Solution] [Detections] Only display actions options if user has "read" privileges (elastic#78812)
  [babel/register] remove from build (elastic#79176)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Operations Team label for Operations Team v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove babel-register in production
4 participants