-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Break long titles into multiple lines #79580
[Lens] Break long titles into multiple lines #79580
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, thank you @wylieconlon for the find and quick fix. That is definitely my fault, I thought I had kept an eye out for it. LGTM!
I wonder if this wrapOnDot
is something that could be surfaced at a higher level for more plugins to use as it seems pretty helpful.
@cchaos I like the idea of surfacing it at a higher level, since we are also using it in the FieldItem component. It seems like a nice util to add, but I won't do it in this PR. |
This fixes a bug where the delete button was sometimes hidden because of text length issues. The dimension triggers on the right side of Lens are now receiving the same handling as the field names on the left side of Lens, which we are happy with.
Screenshot:
Fixes #79573