Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Break long titles into multiple lines #79580

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

wylieconlon
Copy link
Contributor

@wylieconlon wylieconlon commented Oct 5, 2020

This fixes a bug where the delete button was sometimes hidden because of text length issues. The dimension triggers on the right side of Lens are now receiving the same handling as the field names on the left side of Lens, which we are happy with.

Screenshot:

Screen Shot 2020-10-05 at 5 36 35 PM

Fixes #79573

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.10.0 v7.11.0 labels Oct 5, 2020
@wylieconlon wylieconlon requested review from cchaos, dej611, flash1293, mbondyra and a team October 5, 2020 21:40
@wylieconlon wylieconlon requested a review from a team as a code owner October 5, 2020 21:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
lens 1.0MB 1.0MB +250.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra
Copy link
Contributor

mbondyra commented Oct 6, 2020

Tested with some German words:

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, thank you @wylieconlon for the find and quick fix. That is definitely my fault, I thought I had kept an eye out for it. LGTM!

I wonder if this wrapOnDot is something that could be surfaced at a higher level for more plugins to use as it seems pretty helpful.

@wylieconlon
Copy link
Contributor Author

@cchaos I like the idea of surfacing it at a higher level, since we are also using it in the FieldItem component. It seems like a nice util to add, but I won't do it in this PR.

@wylieconlon wylieconlon merged commit 2de2c70 into elastic:master Oct 6, 2020
@wylieconlon wylieconlon deleted the lens/break-long-triggers branch October 6, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Long operation names can prevent the delete button from being visible
5 participants