Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set content-type header to application/json #7966

Merged
merged 2 commits into from
Aug 9, 2016
Merged

Set content-type header to application/json #7966

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a7414a
Set content-type header to application/json
ycombinator Aug 9, 2016
8cbe46f
Set content-type based on whether body exists and is JSON
ycombinator Aug 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core_plugins/console/public/src/es.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ module.exports.send = function (method, path, data, server, disable_auth_alert)
var options = {
url: '../api/console/proxy?uri=' + encodeURIComponent(path),
data: method == "GET" ? null : data,
contentType: 'application/json',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to assign this based on the actual content type, as of now there are two content types possible, application/json for standard bodies and text/plain for newline-delimited json bodies for APIs like bulk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, good catch re: bulk. Will fix.

cache: false,
crossDomain: true,
type: method,
Expand Down