Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Resolver][Bug] Remove backdrop blur: visual regression #79668

Merged
merged 1 commit into from
Oct 6, 2020
Merged

[Security Solution][Resolver][Bug] Remove backdrop blur: visual regression #79668

merged 1 commit into from
Oct 6, 2020

Conversation

bkimmel
Copy link
Contributor

@bkimmel bkimmel commented Oct 6, 2020

Summary

The backdrop filter that was added causes visual regressions when the bounding box for the pills overlays other resolver nodes. Removing it for now.

For maintainers

@bkimmel bkimmel added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Resolver Security Solution Resolver feature v7.10.0 labels Oct 6, 2020
@bkimmel bkimmel requested review from a team as code owners October 6, 2020 14:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Resolver)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
securitySolution 10.4MB 10.4MB -52.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bkimmel bkimmel merged commit 55af328 into elastic:master Oct 6, 2020
@bkimmel bkimmel deleted the resolver/rollback-backdrop-filter branch October 6, 2020 15:43
@bkimmel bkimmel mentioned this pull request Oct 6, 2020
Merged
bkimmel added a commit that referenced this pull request Oct 6, 2020
@bkimmel
Remove backdrop blur: visual regression (#79668) (#79736)
1fa9677
lindseypoli
lindseypoli reviewed Oct 6, 2020
View reviewed changes
Copy link

@lindseypoli lindseypoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindseypoli lindseypoli lindseypoli left review comments

@james-elastic james-elastic james-elastic approved these changes

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@oatkiller oatkiller oatkiller approved these changes

Assignees
No one assigned
Labels
Feature:Resolver Security Solution Resolver feature release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bkimmel @elasticmachine @kibanamachine @oatkiller @michaelolo24 @lindseypoli @james-elastic