-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A11y tests for roles page #79900
A11y tests for roles page #79900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bummer about the rule skips we had to implement for EUI issues but I think this is the right path forward 👍
Thanks @myasonik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security changes LGTM -- added data-test-subj
in two files 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - only code review and Jenkins results
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
@bhavyarm I merged your PR to 7.10 branch but you still need to create a 7.x backport |
Thanks @LeeDr |
# Conflicts: # x-pack/test/accessibility/config.ts
Meta - #51456
a11y tests for roles page plus
Modifications to users.ts (unskipped tests)
Add these to skip a11y checks on ids in axe analyzer helped to deal with eui bug elastic/eui#2841: