Clone monitored state before modifying #8066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 similar comment
|
LGTM |
| @@ -19,7 +19,7 @@ function stateMonitor(state, defaultState) { | |||
| } | |||
|
|
|||
| function getStatus() { | |||
| const currentState = filterState(state.toJSON()); | |||
| const currentState = filterState(cloneDeep(state.toJSON())); | |||
There was a problem hiding this comment.
Could you please add a comment here which explains the intent? Basically a terser version of this PR's description: "Get a copy of the underlying state's objects instead of the reference returned by toJSON(), because we need to mutate this object, e.g. in filterState."
|
One small request, looks great to me otherwise :) |
|
Can you create a beta1 blocker issue to track forward porting this to master? |
|
yussir EDIT: opened #8068 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8060
The monitor app state module was using
toJSON()to compare the state to see if things changed, and it was optionally ignoring props by mutating the state and just setting the value totrue.The problem is that
toJSON()only returns the state by reference, so the monitor was mutating the state and breaking the listeners, which was causing the sidebar to collapse when changes were applied.This PR does a
cloneDeepon the output before modifying and comparing the state.