Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.10] Fix error rate sorting in services list (#80764) #80790

Merged
merged 1 commit into from
Oct 16, 2020
Merged

[7.10] Fix error rate sorting in services list (#80764) #80790

merged 1 commit into from
Oct 16, 2020

Conversation

smith
Copy link
Contributor

@smith smith commented Oct 16, 2020

Backports the following commits to 7.10:

@smith
Fix error rate sorting in services list (elastic#80764)
ca73544 
The field was incorrectly labeled `errorsPerMinute` instead of `transactionErrorRate` (probably left over from before when we switched to using error rate.)

Use `-1` for the fallback sort so "N/A" appears after "0%"

Fixes elastic#80473.
@smith smith added the backport label Oct 16, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
apm 4.1MB 4.1MB +16.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit c234042 into elastic:7.10 Oct 16, 2020
@smith smith deleted the backport/7.10/pr-80764 branch October 16, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smith @kibanamachine