-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry] Add method to enable endpoint security data usage example #80940
Merged
Bamieh
merged 9 commits into
elastic:master
from
Bamieh:telemetry/endpoint_security_example_setup_method
Oct 20, 2020
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a8a6140
Add method to enable example
Bamieh 4b72e62
call isSecurityExampleEnabled
Bamieh 22cdb86
Merge branch 'master' of github.com:elastic/kibana into telemetry/end…
Bamieh 8b15931
see 'an' example
Bamieh 45eedf0
update snapshot
Bamieh 2fd8087
Merge branch 'master' of github.com:elastic/kibana into telemetry/end…
Bamieh f3b885b
i18n check
Bamieh 1f33776
Merge branch 'master' of github.com:elastic/kibana into telemetry/end…
Bamieh a0d28d8
fix types after another pr merged
Bamieh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
62 changes: 61 additions & 1 deletion
62
...gement_section/public/components/__snapshots__/telemetry_management_section.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit, but might be more DRY to just set these (
isSecurityExampleEnabled
&&onQueryMatchChange
) in abeforeEach
at the top of the relevant describe blocks since they don't seem to change for any of the testsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually prefer to keep them like that in the tests to make it easier to read what is happening. each
it
has almost all it needs encapsulated inside it, so you can update/refactor the tests more easily if needed in the future.