-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tsconfig for url_forwarding #81177
Conversation
Also add missing pieces to kibana_react, as a follow-up to elastic#80992. References elastic#80508 References elastic#81003
I had to add a bunch of the missing exports to new .d.ts files in kibana_legacy. The errors didn't show up when. I ran When I run
Do I have an incorrect path or missing compiler option or do we need to add missing .d.ts for all the projects that reference them? The files failing with |
I don't see any errors for {
"extends": "../../../tsconfig.base.json",
"compilerOptions": {
"composite": true,
"outDir": "./target/types",
"emitDeclarationOnly": true,
"declaration": true,
"declarationMap": true
},
"include": ["../../../typings/**/*", "public/**/*"],
"references": [{
"path": "../../core/tsconfig.json"
}, {
"path": "../kibana_legacy/tsconfig.json"
}]
} and can see only the next errors when run
@smith I'm not sure what tsconfig |
@restrry ok the errors you saw are the ones I'm fixing in this PR by adding the .d.ts files to kibana_legacy. The ones I'm seeing in core must be because of something else. I assumed running |
@elasticmachine merge upstream |
Currently blocked by elastic#81177 because it fails on `MockedKeys/DeeplyMockedKeys`
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a lot is going on in this PR and I don't understand half of it - focused on the KibanaApp changes, those LGTM (only adding additional types). Left a nit about a type that can be improved, but as there are many more missing and these utilities are deprecated anyway it's low priority.
IController | ||
>>; | ||
export const createTopNavHelper: ( | ||
options: unknown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This is NavigationPublicPluginStart['ui']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that. I think I'll leave it since it's not widely used and I wanted to be as generic as possible since I'm not familiar with the code.
Also add missing pieces to kibana_react, as a follow-up to elastic#80992. References elastic#80508 References elastic#81003 # Conflicts: # tsconfig.json
…kibana into task-manager/lost-connectivity * 'task-manager/lost-connectivity' of github.com:gmmorris/kibana: skips overview tests (elastic#81877) [Security Solution][Case] Fix connector's labeling (elastic#81824) [Maps] Fix EMS test (elastic#81856) [Security Solutions][Detections] - Fix bug, last response not showing for disabled rules (elastic#81783) skip flaky suite (elastic#81853) Add tsconfig for url_forwarding (elastic#81177) skip flaky suite (elastic#81844) check for server enabled (elastic#81818) [Seurity Solution][Case] Create case plugin client (elastic#81018) [Security Solutions][Detection Engine] Changes wording for threat matches and rules (elastic#81334) [Security Solution] critical pref bug with browser fields reducer
Also:
MockedKeys
andDeeplyMockedKeys
.References #80508
References #81003