[SecuritySolution][Unit Tests] - fix flakey unit test #81239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yctercero
added
release_note:skip
madirey
reviewed
Oct 20, 2020
| Number(dateMath.parse('now-220m')?.format('x')), | ||
| Number(dateMath.parse('now')?.format('x')) | ||
| Date.parse('2020-02-20T02:15:54.037Z'), | ||
| Date.parse('2020-02-20T05:57:54.037Z') |
There was a problem hiding this comment.
I think this is 222 minutes... does that matter? Also, is the test description correct?
There was a problem hiding this comment.
I updated the description a bit. That test is just looking for the difference in time to be between 180-240 minutes, so 222 is fine. Let me know if I missed something with the descriptions!
There was a problem hiding this comment.
This is perfect, thank you!
FrankHassanabad
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Just one question from @madirey that I am curious about as well. But overall this looks good to checkin.
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/monitoring/elasticsearch/node_detail·js.Monitoring app Elasticsearch node detail Offline Node "before all" hook for "should show node summary of NA for offline node"Standard OutStack TraceMetrics [docs]
History
To update your PR or re-run it, just comment with: |
madirey
approved these changes
Oct 21, 2020
yctercero
added a commit
to yctercero/kibana
that referenced
this pull request
Oct 21, 2020
### Summary Fixes flakey unit test that was using dateMath as opposed to a fixed date for consistent testing.
yctercero
added a commit
to yctercero/kibana
that referenced
this pull request
Oct 21, 2020
### Summary Fixes flakey unit test that was using dateMath as opposed to a fixed date for consistent testing.
yctercero
added a commit
that referenced
this pull request
Oct 21, 2020
yctercero
added a commit
that referenced
this pull request
Oct 21, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 21, 2020
…arm-phase-to-formlib * 'master' of github.com:elastic/kibana: (55 commits) [UX] Fix map color variance and apply proper filter for extended stats (elastic#81106) [User Experience] Use EuiSelect for percentiles instead of SuperSelect (elastic#81082) [DOCS] Add link for monitoring ssl settings (elastic#81057) [test] Await loading indicator in monitoring test (elastic#81279) [ILM] Minor copy and link additions to cloud CTA for cold phase (elastic#80512) [Mappings editor] Add scaled_float and date_range comp integration tests (elastic#81287) [Discover] Deangularize context.app (elastic#80851) [O11y Overview] Add code to display/hide UX section when appropriate (elastic#80873) [Discover] Extend DiscoverNoResults component to show different message on error (elastic#79671) Fix tagcloud word overlapping (elastic#81161) [Security Solution] Fixes flaky test rules (elastic#81040) Changed the code to avoid tech debt with hacky solutions after receiving comments on EUI issue reported about this problem. (elastic#81183) [Security Solution][All] Replace old markdown renderer with the new one (elastic#80301) Add namespaced version of the API call (elastic#81278) [ML] Data Frame Analytics: Fix race condition and support for feature influence legacy format. (elastic#81123) [Fleet] Fix POLICY_CHANGE action creation for new policy (elastic#81236) [Security Solution][Endpoint][Admin] Malware user notification checkbox (elastic#78084) [SecuritySolution][Unit Tests] - fix flakey unit test (elastic#81239) skip flaky suite (elastic#81264) [Maps] fix top-level Map page is called 'Kibana' (elastic#81238) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared/forcemerge_field.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes flakey unit test that was using dateMath as opposed to a fixed date for consistent testing.
Checklist