[User experience] Fix JS error rate #81512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerry350
force-pushed
the
78926-fix-ux-error-rate
branch
from
2de8bfb to
4e9479d
Compare
shahzad31
requested changes
Oct 26, 2020
botelastic
bot
added
Team:APM
|
Pinging @elastic/apm-ui (Team:apm) |
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
added
release_note:skip
- Exclude fetchStart exists filter for page views chart query - Remove JS error rate from UI - Query all JS errors, not just page-load transactions
|
@shahzad31 This is ready for another look. Addressed your feedback and added the tweaks from #78926 (comment). |
shahzad31
approved these changes
Oct 27, 2020
|
Hrm, functional test failure is unrelated 😞 |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream Flaky maps tests have been skipped upstream, giving this another whirl 🤞 |
💛 Build succeeded, but was flaky
Test FailuresChrome UI Functional Tests.test/functional/apps/discover/_doc_table·ts.discover app discover doc table expand a document row "before each" hook for "should expand the detail row when the toggle arrow is clicked"Standard OutStack TraceMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
Kerry350
added a commit
to Kerry350/kibana
that referenced
this pull request
Oct 28, 2020
* Query adjustments for getClientMetrics * Remove error rate from JS errors section
Kerry350
added a commit
to Kerry350/kibana
that referenced
this pull request
Oct 28, 2020
* Query adjustments for getClientMetrics * Remove error rate from JS errors section
Kerry350
added a commit
that referenced
this pull request
Oct 28, 2020
Kerry350
added a commit
that referenced
this pull request
Oct 28, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 29, 2020
…kibana into alerts/convert-to-tm-intervals * 'alerts/convert-to-tm-intervals' of github.com:gmmorris/kibana: (88 commits) fixed jest APM Experiments settings (elastic#81554) [Resolver] Enable resolver test plugin tests (elastic#81339) Add TS project references for inspector (elastic#81792) Add uri decode to es_ui_shared and fix navigation issues with special characters (elastic#80835) [Fleet] Rename ingestManager translations fleet (elastic#81837) [Logs UI] Transmit and render array field values in log entries (elastic#81385) Audit Logging: use the original url (elastic#81282) [User experience] Fix JS error rate (elastic#81512) [UX] Add median/percentile info in titles (elastic#79824) Support export for SO with circular refs (elastic#81582) Get rid of global types (elastic#81739) [APM] Fix precommit script (elastic#81594) skips overview tests (elastic#81877) [Security Solution][Case] Fix connector's labeling (elastic#81824) Added simple test, which only covers successful case when edit happened right after task was complete previous execution [Maps] Fix EMS test (elastic#81856) [Security Solutions][Detections] - Fix bug, last response not showing for disabled rules (elastic#81783) skip flaky suite (elastic#81853) Fixed type checks and unit tests ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR partially fixes #78926. It incorporates feedback from #78926 (comment) onwards.
Namely:
Make sure
exists: { field: 'transaction.marks.navigationTiming.fetchStart' }doesn't exclude documents in thegetClientMetricsfunction queries (so they can contribute towards the page views value).Derive
page viewsfrom the hit count of the outer query, rather than using avalue_countaggregation (orcardinalityontransaction.id).Note
The
getRumPageLoadTransactionsProjectionprojection is used in a lot of places, so I've added acheckFetchStartFieldExistsparam which is by default set totrue. I didn't want to add a separate projection just for thegetClientMetricsquery. This can be changed, but was the easiest way forward. There's a comment alongside theexiststhat statesAdding this filter to cater for some inconsistent rum data not available on aggregated transactionsbut it's not clear what that RUM data is, and so this should be applied to the smallest piece possible.