-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] convert vector style component to typescript round 1 #81961
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
@@ -110,15 +140,3 @@ export function FieldSelect({ fields, selectedFieldName, onChange, styleName, .. | |||
/> | |||
); | |||
} | |||
|
|||
export const fieldShape = PropTypes.shape({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice we get to remove this
import { IStyleProperty } from '../properties/style_property'; | ||
import { StyleField } from '../style_fields_helper'; | ||
|
||
export interface Props<StaticOptionsType, DynamicOptionsType> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: do we need the Type
-suffix? The compiler will enforce that it's.a type and not an instance.
e.g.:
Props<StaticOptions, DynamicOptions>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the Type
suffix to make the names more explicit on what they are. Once you start adding angle brackets everywhere the names blur together so I figured its more straightforward that they are types and not something other thing. I can remove if needed.
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
…81961) * [Maps] convert vector style component to typescript round 1 * clean up * review feedback Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…82200) * [Maps] convert vector style component to typescript round 1 * clean up * review feedback Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* master: Add derivative function (elastic#81178) [Discover] Deangularize context_app.html, part 3 (elastic#81838) [Visualize] Vis listing page breaks on unknown vis type (elastic#82018) Rename `batchSize` parameter to `batch_size` to be consisten with the API namings guidelines. (elastic#82123) Minor edits in Single Metric Viewer (elastic#82159) [Actions] Fix type contract (elastic#82168) Upgrade EUI to v30.1.1 (elastic#81499) Skip failing ES snapshot test (elastic#82207) Skip ES snapshot failing suite (elastic#82206) [Alerting UI] Grouped list of alert types using producers in Types filter of Alerts tab (elastic#81876) [Maps] convert vector style component to typescript round 1 (elastic#81961) Fix link to upgrade assistant (elastic#82138) Rename "service overview" to "service inventory" (elastic#81933) adjust policy test to drop test for server addresses (elastic#82120) Cleanup/codeowners (elastic#82146) [DOCS] Updates add data content (elastic#81093) [DOCS] Remove index mgmt docs (elastic#82099) [Search] fix cancelation related memory leaks (elastic#81996)
…e-details-overlay * 'master' of github.com:elastic/kibana: (72 commits) [CCR] Update README.md on how to start 2 clusters for testing (elastic#81487) [APM] Scale transaction rate correctly (elastic#82155) Upgrade to hapi version 18 (elastic#80468) [Uptime] Remove custom handling of license enabling (elastic#82019) [Telemetry] Remove `from` and `to` timestamps from usage stats APIs (elastic#81579) Enable send to background in Vega (elastic#82229) Enable send to background in Timelion (elastic#82232) [Actions & Connectors] removes Connector flyouts after usage (elastic#82126) Add derivative function (elastic#81178) [Discover] Deangularize context_app.html, part 3 (elastic#81838) [Visualize] Vis listing page breaks on unknown vis type (elastic#82018) Rename `batchSize` parameter to `batch_size` to be consisten with the API namings guidelines. (elastic#82123) Minor edits in Single Metric Viewer (elastic#82159) [Actions] Fix type contract (elastic#82168) Upgrade EUI to v30.1.1 (elastic#81499) Skip failing ES snapshot test (elastic#82207) Skip ES snapshot failing suite (elastic#82206) [Alerting UI] Grouped list of alert types using producers in Types filter of Alerts tab (elastic#81876) [Maps] convert vector style component to typescript round 1 (elastic#81961) Fix link to upgrade assistant (elastic#82138) ...
typescript conversion chore.