do not overencode unhashed states #8212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this blocked on #8209? |
|
Yeah |
By default, the url.format function stringifies the query object and encodes each parameter with `encodeURIComponent()`. This is effective, but does not match the native browser behavior, which is to only encode the non-`pchar` characters as defined by [rfc3986][1]. Because of this, angular's `$location.search()` function uses a function internally called `encodeUriQuery()` to mimic the browser behavior before updating `location.href`. To bring the same funtionality to the `unhashUrl()` function, the `encodeUriQuery()` was extracted into it's own package and used as the escape handler for `querystring.stringify()` [1]: https://www.ietf.org/rfc/rfc3986.txt
spalger
force-pushed
the
fix/doNotOverencodeUnhashedStates
branch
from
9c2bfba to
d9dac3f
Compare
|
LGTM |
1 similar comment
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Sep 10, 2016
--------- **Commit 1:** [state/unhashUrl] use encode-uri-query to generate cleanly encoded urls By default, the url.format function stringifies the query object and encodes each parameter with `encodeURIComponent()`. This is effective, but does not match the native browser behavior, which is to only encode the non-`pchar` characters as defined by [rfc3986][1]. Because of this, angular's `$location.search()` function uses a function internally called `encodeUriQuery()` to mimic the browser behavior before updating `location.href`. To bring the same funtionality to the `unhashUrl()` function, the `encodeUriQuery()` was extracted into it's own package and used as the escape handler for `querystring.stringify()` [1]: https://www.ietf.org/rfc/rfc3986.txt * Original sha: d9dac3f * Authored by spalger <spalger@users.noreply.github.com> on 2016-09-09T22:39:57Z
elastic-jasper
added a commit
that referenced
this pull request
Sep 10, 2016
--------- **Commit 1:** [state/unhashUrl] use encode-uri-query to generate cleanly encoded urls By default, the url.format function stringifies the query object and encodes each parameter with `encodeURIComponent()`. This is effective, but does not match the native browser behavior, which is to only encode the non-`pchar` characters as defined by [rfc3986][1]. Because of this, angular's `$location.search()` function uses a function internally called `encodeUriQuery()` to mimic the browser behavior before updating `location.href`. To bring the same funtionality to the `unhashUrl()` function, the `encodeUriQuery()` was extracted into it's own package and used as the escape handler for `querystring.stringify()` [1]: https://www.ietf.org/rfc/rfc3986.txt * Original sha: d9dac3f * Authored by spalger <spalger@users.noreply.github.com> on 2016-09-09T22:39:57Z
epixa
added a commit
that referenced
this pull request
Sep 10, 2016
[backport] PR #8212 to 5.x - do not overencode unhashed states
epixa
added a commit
that referenced
this pull request
Sep 10, 2016
[backport] PR #8212 to 5.0 - do not overencode unhashed states
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Jan 5, 2017
**Commit 1:** [state/unhashUrl] use encode-uri-query to generate cleanly encoded urls By default, the url.format function stringifies the query object and encodes each parameter with `encodeURIComponent()`. This is effective, but does not match the native browser behavior, which is to only encode the non-`pchar` characters as defined by [rfc3986][1]. Because of this, angular's `$location.search()` function uses a function internally called `encodeUriQuery()` to mimic the browser behavior before updating `location.href`. To bring the same funtionality to the `unhashUrl()` function, the `encodeUriQuery()` was extracted into it's own package and used as the escape handler for `querystring.stringify()` [1]: https://www.ietf.org/rfc/rfc3986.txt * Original sha: d9dac3f * Authored by spalger <spalger@users.noreply.github.com> on 2016-09-09T22:39:57Z
kobelb
added a commit
that referenced
this pull request
Jan 5, 2017
**Commit 1:** [state/unhashUrl] use encode-uri-query to generate cleanly encoded urls By default, the url.format function stringifies the query object and encodes each parameter with `encodeURIComponent()`. This is effective, but does not match the native browser behavior, which is to only encode the non-`pchar` characters as defined by [rfc3986][1]. Because of this, angular's `$location.search()` function uses a function internally called `encodeUriQuery()` to mimic the browser behavior before updating `location.href`. To bring the same funtionality to the `unhashUrl()` function, the `encodeUriQuery()` was extracted into it's own package and used as the escape handler for `querystring.stringify()` [1]: https://www.ietf.org/rfc/rfc3986.txt * Original sha: d9dac3f * Authored by spalger <spalger@users.noreply.github.com> on 2016-09-09T22:39:57Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** [state/unhashUrl] use encode-uri-query to generate cleanly encoded urls By default, the url.format function stringifies the query object and encodes each parameter with `encodeURIComponent()`. This is effective, but does not match the native browser behavior, which is to only encode the non-`pchar` characters as defined by [rfc3986][1]. Because of this, angular's `$location.search()` function uses a function internally called `encodeUriQuery()` to mimic the browser behavior before updating `location.href`. To bring the same funtionality to the `unhashUrl()` function, the `encodeUriQuery()` was extracted into it's own package and used as the escape handler for `querystring.stringify()` [1]: https://www.ietf.org/rfc/rfc3986.txt * Original sha: 41d439946b0a510daa55e5695238ba4e6bbe58bf [formerly d9dac3f] * Authored by spalger <spalger@users.noreply.github.com> on 2016-09-09T22:39:57Z Former-commit-id: c257bbb
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8212 to 5.x - do not overencode unhashed states Former-commit-id: f4f0dda
mgadewoll
added a commit
that referenced
this pull request
Dec 19, 2024
`v98.1.0-borealis.0`⏩`v98.2.1-borealis.2` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- # `@elastic/eui` ## [`v98.2.1`](https://github.com/elastic/eui/releases/v98.2.1) - Updated the EUI theme color values to use a full 6 char hex code format ([#8244](elastic/eui#8244)) ## [`v98.2.0`](https://github.com/elastic/eui/releases/v98.2.0) - Added two new icons: `contrast` and `contrastHigh` ([#8216](elastic/eui#8216)) - Updated `EuiDataGrid` content to have a transparent background. ([#8220](elastic/eui#8220)) **Accessibility** - When the tooltips components (`EuiTooltip`, `EuiIconTip`) are used inside components that handle the Escape key (like `EuiFlyout` or `EuiModal`), pressing the Escape key will now only close the tooltip and not the entire wrapping component. ([#8140](elastic/eui#8140)) - Improved the accessibility of `EuiCodeBlock`s by ([#8195](elastic/eui#8195)) - adding screen reader only labels - adding `role="dialog"` on in fullscreen mode - ensuring focus is returned on closing fullscreen mode # Borealis updates - [Visual Refresh] Update color token mappings ([#8211](elastic/eui#8211)) - [Visual Refresh] Introduce shared popover arrow styles to Borealis ([#8212](elastic/eui#8212)) - [Visual Refresh] Add forms.maxWidth token ([#8221](elastic/eui#8221)) - [Visual Refresh] Set darker shade for subdued text ([#8224](elastic/eui#8224)) - [Visual Refresh] Remove support for accentSecondary badges ([#8224](elastic/eui#8227)) - [Visual Refresh] Add severity vis colors ([#8247](elastic/eui#8247)) - [Visual Refresh] Fix transparent color variable definitions ([8249](elastic/eui#8249)) - [Visual Refresh] Update EuiToken colors ([8250](elastic/eui#8250)) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the url.format function stringifies the query object and encodes each parameter with
encodeURIComponent(). This is effective, but does not match the native browser behavior, which is to only encode the non-pcharcharacters as defined by rfc3986. Because of this, angular's$location.search()function uses a function internally calledencodeUriQuery()to mimic the browser behavior before updatinglocation.href.To bring the same funtionality to the
unhashUrl()function, theencodeUriQuery()was extracted into it's own package and used as the escape handler forquerystring.stringify()