[Uptime / synthetics] Add secondary sort #82281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerry350
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
andrewvc
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
LGTM
Manually tested. I'm OK with the lack of tests given that:
- This is experimental
- This actually works fine on single node clusters without this
- We have a separate issue for a synthetics test suite that should catch this Add E2E Test Suite / Example synthetics#115
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
Kerry350
added a commit
to Kerry350/kibana
that referenced
this pull request
Nov 2, 2020
Fixes ordering bug
Kerry350
added a commit
to Kerry350/kibana
that referenced
this pull request
Nov 2, 2020
Fixes ordering bug
Kerry350
added a commit
that referenced
this pull request
Nov 2, 2020
Kerry350
added a commit
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a secondary sort to the
getJourneyStepsquery following the changes in a Heartbeat patch for timing. Ensures that steps aren't rendered out of order.