Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [App Search] Added the log retention panel to the Settings page (#82982) #83068

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

JasonStoltz
Copy link
Member

Backports the following commits to 7.x:

…tic#82982)

* Added LogRententionPanel

* i18n

* fix axe failure

* Update x-pack/plugins/enterprise_search/public/applications/app_search/components/settings/log_retention/messaging/determine_tooltip_content.test.ts

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

* PR Feeback: interpolation

* Apply suggestions from code review

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 453 460 +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 666.2KB 681.0KB +14.8KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@JasonStoltz JasonStoltz merged commit e9867e0 into elastic:7.x Nov 10, 2020
@JasonStoltz JasonStoltz deleted the backport/7.x/pr-82982 branch November 10, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants