Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Alerting] Moves the Index & Geo Threshold UIs into the Stack Alerts Public Plugin (#82951) #83316

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

gmmorris
Copy link
Contributor

Backports the following commits to 7.x:

…Public Plugin (elastic#82951)

This PR includes the following refactors:
1. Moves the Index Pattern Api from _Stack Alerts_ to the _Server_ plugin of _Trigger Actions UI_. This fixes a potential bug where a user could disable the _Stack Alerts_ plugin and inadvertently break the UI of the _ES Index _ action type.
2. Extracts the UI components for _Index Threshold_ and _Geo Threshold_ from the _Trigger Actions UI_ plugin and moves them into _Stack Alerts_.
# Conflicts:
#	packages/kbn-optimizer/limits.yml
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
stackAlerts - 31 +31
triggersActionsUi 297 275 -22
total +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackAlerts - 79.8KB +79.8KB
triggersActionsUi 1.5MB 1.4MB -95.4KB
total -15.7KB

Distributable file count

id before after diff
default 43128 43135 +7

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
stackAlerts - 14.3KB +14.3KB
triggersActionsUi 133.3KB 140.2KB +6.9KB
total +21.2KB
Unknown metric groups

async chunk count

id before after diff
stackAlerts - 2 +2
triggersActionsUi 33 31 -2
total -0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gmmorris gmmorris merged commit 5f36a27 into elastic:7.x Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants