-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirects for drilldown links #83325
Conversation
This fix would work for 7.10.x branch and for future 7.10.1 release, Which are:
In addition to change in this pr, I think we also need to make ^^ older links valid (at least point to something). I am not sure what is an approach we usually take in our docs in such cases |
I am looking at build: As I understand we need
to open a redirect page, but they don't :( Instead now
are working, but it is not exactly what we need I think we should create a |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except one link (comment below).
Also this points directly to 7.10
?
Then, I assume after this merged we should make them same pr to master and also backport to 7.x
.
I wonder if we should instead merge this into master and backport to 7.x
and 7.10
following usual backport process?
docs/redirects.asciidoc
Outdated
[[trigger-picker]] | ||
=== Picking a trigger for a URL drilldown | ||
|
||
This page has moved. Refer to <<url-drilldown>>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link leads to itself. I think it should lead to url-drilldowns
?
Closed in favor of #83846. |
Summary
loses #83268