Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirects for drilldown links #83325

Closed
wants to merge 8 commits into from

Conversation

KOTungseth
Copy link
Contributor

@KOTungseth KOTungseth commented Nov 12, 2020

Summary

loses #83268

@KOTungseth KOTungseth added release_note:skip Skip the PR/issue when compiling release notes Feature:Drilldowns Embeddable panel Drilldowns v7.10.0 v7.11.0 labels Nov 12, 2020
@KOTungseth KOTungseth self-assigned this Nov 12, 2020
@LeeDr LeeDr added v7.10.1 and removed v7.10.0 labels Nov 12, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 657.9KB 657.9KB -18.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant
Copy link
Contributor

Dosant commented Nov 17, 2020

This fix would work for 7.10.x branch and for future 7.10.1 release,
but 7.10.0 was released with docsLinks prior #82081

Which are:

https://www.elastic.co/guide/en/kibana/7.10/url-drilldown.html#trigger-picker
https://www.elastic.co/guide/en/kibana/7.10/url-drilldown.html#templating
https://www.elastic.co/guide/en/kibana/7.10/url-drilldown.html#variables

In addition to change in this pr, I think we also need to make ^^ older links valid (at least point to something). I am not sure what is an approach we usually take in our docs in such cases

@Dosant
Copy link
Contributor

Dosant commented Nov 17, 2020

I am looking at build:
https://kibana_83325.docs-preview.app.elstc.co/

As I understand we need

https://kibana_83325.docs-preview.app.elstc.co/guide/en/kibana/7.10/url-drilldown.html#trigger-picker
https://kibana_83325.docs-preview.app.elstc.co/guide/en/kibana/7.10/url-drilldown.html#templating
https://kibana_83325.docs-preview.app.elstc.co/guide/en/kibana/7.10/url-drilldown.html#variables

to open a redirect page, but they don't :(

Instead now

https://kibana_83325.docs-preview.app.elstc.co/guide/en/kibana/7.10/trigger-picker.html
https://kibana_83325.docs-preview.app.elstc.co/guide/en/kibana/7.10/templating.html
https://kibana_83325.docs-preview.app.elstc.co/guide/en/kibana/7.10/variables.html

are working, but it is not exactly what we need

I think we should create a <url-drilldown> entry in redirects with 3 subsections inside

@KOTungseth KOTungseth changed the title Fixes Go to URL links Redirects for dashboard links Nov 18, 2020
@KOTungseth KOTungseth changed the title Redirects for dashboard links Redirects for drilldown links Nov 18, 2020
@Dosant
Copy link
Contributor

Dosant commented Nov 19, 2020

@elasticmachine merge upstream

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except one link (comment below).

Also this points directly to 7.10?
Then, I assume after this merged we should make them same pr to master and also backport to 7.x.

I wonder if we should instead merge this into master and backport to 7.x and 7.10 following usual backport process?

[[trigger-picker]]
=== Picking a trigger for a URL drilldown

This page has moved. Refer to <<url-drilldown>>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link leads to itself. I think it should lead to url-drilldowns?

(https://kibana_83325.docs-preview.app.elstc.co/guide/en/kibana/current/drilldowns.html#url-drilldowns)

@KOTungseth
Copy link
Contributor Author

Closed in favor of #83846.

@KOTungseth KOTungseth closed this Nov 19, 2020
@KOTungseth KOTungseth deleted the docs/drilldown-links branch November 19, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Drilldowns Embeddable panel Drilldowns release_note:skip Skip the PR/issue when compiling release notes v7.10.1 v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants