Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting UI] Fix console error when setting connector params #83333

Merged
merged 11 commits into from
Nov 17, 2020
Merged

[Alerting UI] Fix console error when setting connector params #83333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
14363fa
Fixing console errors
ymao1 Nov 12, 2020
54e434b
Merge branch 'master' of https://github.com/elastic/kibana into conso…
ymao1 Nov 12, 2020
7eed847
Setting defaults for undefined inputs in text area/field with message…
ymao1 Nov 12, 2020
5e9463a
Cleanup
ymao1 Nov 12, 2020
51567dc
Cleanup
ymao1 Nov 12, 2020
c144d02
Fixing pagerduty timestamp validation
ymao1 Nov 12, 2020
d457051
Merge branch 'master' of https://github.com/elastic/kibana into conso…
ymao1 Nov 12, 2020
a26a4f9
Fixing test
ymao1 Nov 12, 2020
d3f1adc
Merge branch 'master' of https://github.com/elastic/kibana into conso…
ymao1 Nov 16, 2020
d8d16eb
Pagerduty params
ymao1 Nov 16, 2020
a0c8be0
Reverting unnecessary changes
ymao1 Nov 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ns/triggers_actions_ui/public/application/components/text_area_with_message_variables.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export const TextAreaWithMessageVariables: React.FunctionComponent<Props> = ({
fullWidth
isInvalid={errors && errors.length > 0 && inputTargetValue !== undefined}
name={paramsProperty}
value={inputTargetValue}
value={inputTargetValue || ''}
data-test-subj={`${paramsProperty}TextArea`}
onChange={(e: React.ChangeEvent<HTMLTextAreaElement>) => onChangeWithMessageVariable(e)}
onFocus={(e: React.FocusEvent<HTMLTextAreaElement>) => {
Expand Down
2 changes: 1 addition & 1 deletion ...s/triggers_actions_ui/public/application/components/text_field_with_message_variables.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export const TextFieldWithMessageVariables: React.FunctionComponent<Props> = ({
id={`${paramsProperty}Id`}
isInvalid={errors && errors.length > 0 && inputTargetValue !== undefined}
data-test-subj={`${paramsProperty}Input`}
value={inputTargetValue}
value={inputTargetValue || ''}
onChange={(e: React.ChangeEvent<HTMLInputElement>) => onChangeWithMessageVariable(e)}
onFocus={(e: React.FocusEvent<HTMLInputElement>) => {
setCurrentTextElement(e.target);
Expand Down
4 changes: 1 addition & 3 deletions ...ers_actions_ui/public/application/sections/action_connector_form/connector_add_flyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,8 @@ export const ConnectorAddFlyout = ({
const [isSaving, setIsSaving] = useState<boolean>(false);

const closeFlyout = useCallback(() => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the following lines because I was seeing another console error when saving a connector. With this PR #82126, the connector flyouts are destroyed when closed instead of hidden, so setting these states on closing was causing a Warning: Can't perform a React state update on an unmounted component. browser error.

setActionType(undefined);
setConnector(initialConnector);
onClose();
}, [onClose, initialConnector]);
}, [onClose]);

const canSave = hasSaveActionsCapability(capabilities);

Expand Down