-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Stop collecting Kibana Usage in bulkUploader #83546
Merged
afharo
merged 2 commits into
elastic:master
from
afharo:monitoring/remove-usageCollection-usage-in-bulk_uploader
Nov 20, 2020
Merged
[Monitoring] Stop collecting Kibana Usage in bulkUploader #83546
afharo
merged 2 commits into
elastic:master
from
afharo:monitoring/remove-usageCollection-usage-in-bulk_uploader
Nov 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.11.0
labels
Nov 17, 2020
3 tasks
afharo
force-pushed
the
monitoring/remove-usageCollection-usage-in-bulk_uploader
branch
from
November 17, 2020 16:31
778834d
to
bf5a108
Compare
afharo
force-pushed
the
monitoring/remove-usageCollection-usage-in-bulk_uploader
branch
from
November 18, 2020 09:47
bf5a108
to
f8a2213
Compare
This was referenced Nov 18, 2020
…move-usageCollection-usage-in-bulk_uploader
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
afharo
added
Feature:Stack Monitoring
Feature:Telemetry
Team:Monitoring
Stack Monitoring team
labels
Nov 19, 2020
Pinging @elastic/stack-monitoring (Team:Monitoring) |
chrisronline
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, very nice work here! Thanks for taking this effort on! LGTM!
afharo
deleted the
monitoring/remove-usageCollection-usage-in-bulk_uploader
branch
November 20, 2020 08:55
afharo
added a commit
that referenced
this pull request
Nov 20, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 20, 2020
* master: (38 commits) [ML] Data frame analytics: Adds functionality to map view (elastic#83710) Add usage collection for savedObject tagging (elastic#83160) [SECURITY_SOLUTION] 145: Advanced Policy Tests (elastic#82898) [APM] Service overview transactions table (elastic#83429) [ML] Fix Single Metric Viewer not loading if job is metric with no partition (elastic#83880) do not export types from 3rd party modules as 'type' (elastic#83803) [Fleet] Allow to send SETTINGS action (elastic#83707) Fixes Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details·ts - Actions and Triggers app Alert Details Alert Instances renders the active alert instances (elastic#83478) [Uptime]Reduce chart height on monitor detail page (elastic#83777) [APM] Prefer `APIReturnType` over `PromiseReturnType` (elastic#83843) [Observability] Fix telemetry for Observability Overview (elastic#83847) [Alerting] Adds generic UI for the definition of conditions for Action Groups (elastic#83278) ensure workload agg doesnt run until next interval when it fails (elastic#83632) [ILM] Policy form should not throw away data (elastic#83077) [Monitoring] Stop collecting Kibana Usage in bulkUploader (elastic#83546) [TSVB] fix wrong imports (elastic#83798) [APM] Correlations UI POC (elastic#82256) list all the refs in tsconfig.json (elastic#83678) Bump jest (and related packages) to v26.6.3 (elastic#83724) Functional tests - stabilize reporting tests for cloud execution (elastic#83787) ...
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Stack Monitoring
Feature:Telemetry
release_note:skip
Skip the PR/issue when compiling release notes
Team:Monitoring
Stack Monitoring team
v7.11.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bulk Uploader (used for the deprecated self-monitoring feature) currently uses
usageCollection
to collect Kibana OpsMetrics and Settings stats every 10s, and every 24h it also collects Kibana Usage.The Kibana Usage won't be needed once we complete #82638, and the 10s-collected stats can be owned by the plugin itself so future changes do not break Monitoring's behaviour.
This PR stops collecting Kibana Usage and implements the OpsMetrics and Settings collectors in the
monitoring
plugin itself. This way it no longer depends onusageCollection
's APIs.Related to #83521.
Checklist
Delete any items that are not applicable to this PR.
For maintainers