-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Redirects for drilldown links #83846
Changes from all commits
d9cc9a3
583172d
c0d5462
15fc55b
d6a9f87
6036bd3
50491e1
caad05c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
[[url_templating]] | ||
[[url_templating-language]] | ||
=== URL templating | ||
|
||
beta[] | ||
|
@@ -137,7 +137,7 @@ Example: | |
|
||
|
||
[float] | ||
[[variables]] | ||
[[url-template-variables]] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change means we also have to change: https://github.com/elastic/kibana/blob/master/src/core/public/doc_links/doc_links_service.ts#L44 I think it is fine to fix |
||
==== URL template variables | ||
|
||
The URL drilldown template has three sources for variables: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,4 +11,4 @@ coming[8.0.0] | |
|
||
// tag::notable-highlights[] | ||
|
||
// end::notable-highlights[] | ||
// end::notable-highlights[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change means we also have to change: https://github.com/elastic/kibana/blob/master/src/core/public/doc_links/doc_links_service.ts#L42
I think it is fine to fix
docsLinks
in separate follow up pr to make current pr move faster through backports (to no trigger whole CI because of code changes) as it's anyway won't hurt 7.10 where we want to fix different problem.Leaving this up to you if you'd like to make this change in current pr