Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Add endpoint policy revision number #83982

Merged
merged 3 commits into from
Nov 24, 2020
Merged

[Security Solution] Add endpoint policy revision number #83982

merged 3 commits into from
Nov 24, 2020

Conversation

pzl
Copy link
Member

@pzl pzl commented Nov 20, 2020 •
edited
Loading

Summary

In endpoint list & details, when showing policy name, show revision number as well

visual preview:
2020-11-20-115817_scrot

with out-of-date indicator:
2020-11-20-115747_scrot

from details pane:
2020-11-23-134937_scrot

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@pzl pzl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Endpoint Elastic Endpoint feature v7.11.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Nov 20, 2020
@pzl pzl requested review from a team as code owners November 20, 2020 20:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

@pzl pzl force-pushed the endpoint-policy-revno branch from 768f57f to 3fee281 Compare November 23, 2020 13:10
paul-tavares
paul-tavares previously approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment/question is around the screen capture of the Details view - should the "out of date" indicator be show next to he revision number instead of below it?

cc/ @bfishel ^^

@bfishel
Copy link

bfishel commented Nov 23, 2020

@paul-tavares @pzl totally agree with Paul that the "out of date" indicator should be next to the revision number!!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.9MB 8.0MB +1.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pzl pzl requested a review from paul-tavares November 23, 2020 21:04
@pzl
Copy link
Member Author

pzl commented Nov 23, 2020

@paul-tavares side-by-side approach ok? cleared your thumb for final signoff

@kevinlog
Copy link
Contributor

Should we have it all on the same line? Policy name, rev and Out of Date? This would be consistent with with the table. We could have the link another part of the Flex Group

@pzl
Copy link
Member Author

pzl commented Nov 23, 2020

For one-letter integration names, it looks that way, but for any real name, it may be better to use two lines.
We have more vertical space here than a table-row, obviously.
So if it is a long name, I'd prefer not to have the policy name truncate in a details view.

Defer to @bfishel

@pzl pzl dismissed paul-tavares’s stale review November 23, 2020 21:30

visual changes to be checked

@pzl
Copy link
Member Author

pzl commented Nov 24, 2020

confirmed with Bonnie offline that keeping rev + out-of-date on the next line is preferred.

@pzl pzl requested review from kevinlog and parkiino November 24, 2020 14:44
@pzl pzl merged commit 72f36b4 into elastic:master Nov 24, 2020
pzl added a commit to pzl/kibana that referenced this pull request Nov 24, 2020
@pzl
[Security Solution] Add endpoint policy revision number (elastic#83982)
3a47402
@pzl pzl mentioned this pull request Nov 24, 2020
Merged
pzl added a commit that referenced this pull request Nov 24, 2020
@pzl
[Security Solution] Add endpoint policy revision number (#83982) (#84226
62c93ef 
)
rylnd added a commit to rylnd/kibana that referenced this pull request Nov 24, 2020
@rylnd
Merge branch 'master' into fix_rule_form_bugs
9e01ff6 
* master: (41 commits)
  [Maps] fix code-owners (elastic#84265)
  [@kbn/utils] Clean target before build (elastic#84253)
  [code coverage] collect for oss integration tests (elastic#83907)
  [APM] Use `asTransactionRate` consistently everywhere (elastic#84213)
  Attempt to fix incremental build error (elastic#84152)
  Unskip "Copy dashboards to space" (elastic#84115)
  Remove expressions.legacy from README (elastic#79681)
  Expression: Add render mode and use it for canvas interactivity (elastic#83559)
  [deb/rpm] Move systemd service to /usr/lib/systemd/system (elastic#83571)
  [Security Solution][Resolver] Allow a configurable entity_id field (elastic#81679)
  [ML] Space permision checks for job deletion (elastic#83871)
  [build] Provide ARM build of RE2 (elastic#84163)
  TSVB should use "histogram:maxBars" and "histogram:barTarget" settings for auto instead of a default 100 buckets (elastic#83628)
  [Workplace Search] Initial rendering of Org Sources (elastic#84164)
  update geckodriver to 0.28 (elastic#84085)
  Fix timelion vis escapes single quotes (elastic#84196)
  [Security Solution] Fix incorrect time for dns histogram (elastic#83532)
  [DX] Bump TS version to v4.1 (elastic#83397)
  [Security Solution] Add endpoint policy revision number (elastic#83982)
  [Fleet] Integration Policies List view (elastic#83634)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlog kevinlog kevinlog approved these changes

@paul-tavares paul-tavares Awaiting requested review from paul-tavares

@parkiino parkiino Awaiting requested review from parkiino

Assignees
No one assigned
Labels
Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pzl @elasticmachine @bfishel @kibanamachine @kevinlog @paul-tavares