Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create.asciidoc - Url examples for api in specific space was missing the /api section #84046

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Update create.asciidoc - Url examples for api in specific space was missing the /api section #84046

merged 2 commits into from
Dec 1, 2020

Conversation

balooka
Copy link
Contributor

@balooka balooka commented Nov 23, 2020

The url templates provided for call of the API with space information was missing the /api/ section in it.

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@balooka
Copy link
Contributor Author

balooka commented Nov 23, 2020

Apologies as it seems I'm not following the guidelines, was hoping a "simple" documentation change would work out easy,

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@pmuellr
Copy link
Member

pmuellr commented Nov 25, 2020

No worries @balooka, thanks for the PR!

I've added a label to direct to the right team, someone from there will help move this through the system.

@jdddog jdddog mentioned this pull request Nov 30, 2020
Closed
KOTungseth
KOTungseth approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this :)

legrego
legrego requested changes Nov 30, 2020
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, but I think we need to point this to master instead of 7.10. We can take care of the backports as needed

@gchaps
Copy link
Contributor

gchaps commented Nov 30, 2020

@legrego master lists only three requests. Is that correct?

POST :/api/saved_objects/
POST :/api/saved_objects//
POST :/s/<space_id>/saved_objects/

@legrego
Copy link
Member

legrego commented Nov 30, 2020

In addition to those three, we should also have:

POST :/s/<space_id>/saved_objects/<type>/<id>

@balooka @spalger
Update create.asciidoc
611fdaa 
The url templates provided for call of the API with space information was missing the /api/ section in it.

(cherry picked from commit 35f1cc16eaa29666d7212402f57ab17858ebc96d)
@spalger spalger changed the base branch from 7.10 to master November 30, 2020 20:58
@spalger
Copy link
Contributor

spalger commented Nov 30, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented Nov 30, 2020

jenkins test this

gchaps
gchaps approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gchaps
Copy link
Contributor

gchaps commented Nov 30, 2020

@legrego Can you please take another look. Here is a preview:

https://kibana_84046.docs-preview.app.elstc.co/guide/en/kibana/master/saved-objects-api-create.html

legrego
legrego approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gchaps gchaps merged commit 5420177 into elastic:master Dec 1, 2020
This was referenced Dec 1, 2020
Merged
Merged
gchaps pushed a commit to gchaps/kibana that referenced this pull request Dec 1, 2020
@balooka @kibanamachine @gchaps
Update create.asciidoc (elastic#84046)
2104de7 
The url templates provided for call of the API with space information was missing the /api/ section in it.

(cherry picked from commit 35f1cc16eaa29666d7212402f57ab17858ebc96d)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gchaps pushed a commit to gchaps/kibana that referenced this pull request Dec 1, 2020
@balooka @kibanamachine @gchaps
Update create.asciidoc (elastic#84046)
a253244 
The url templates provided for call of the API with space information was missing the /api/ section in it.

(cherry picked from commit 35f1cc16eaa29666d7212402f57ab17858ebc96d)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@gchaps gchaps mentioned this pull request Dec 1, 2020
Merged
gchaps pushed a commit to gchaps/kibana that referenced this pull request Dec 1, 2020
@balooka @kibanamachine @gchaps
Update create.asciidoc (elastic#84046)
3f0eb74 
The url templates provided for call of the API with space information was missing the /api/ section in it.

(cherry picked from commit 35f1cc16eaa29666d7212402f57ab17858ebc96d)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@gchaps gchaps mentioned this pull request Dec 1, 2020
Merged
gchaps pushed a commit to gchaps/kibana that referenced this pull request Dec 1, 2020
@balooka @gchaps
Update create.asciidoc (elastic#84046)
29dba90 
The url templates provided for call of the API with space information 
was missing the /api/ section in it.

(cherry picked from commit 35f1cc16eaa29666d7212402f57ab17858ebc96d)

Co-authored-by: Kibana Machine 
<42973632+kibanamachine@users.noreply.github.com>
@gchaps gchaps mentioned this pull request Dec 1, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 1, 2020
@gmmorris
Merge branch 'master' into alerts/custom-recovery-action-group
3421a0f 
* master: (63 commits)
  Revert the Revert of "[Alerting] renames Resolved action group to Recovered (elastic#84123)"  (elastic#84662)
  declare kbn/monaco dependency on kbn/i18n explicitly (elastic#84660)
  Remove unscripted fields from sample data index-pattern saved objects (elastic#84659)
  [ML] Fix unnecessary trigger of wildcard field type search for ML plugin routes. (elastic#84605)
  Update create.asciidoc (elastic#84046)
  [Security Solution][Detections] Fix labels and issue with mandatory fields (elastic#84525)
  Fix flaky test suite (elastic#84602)
  [Security Solution] [Detections] Create a 'partial failure' status for rules (elastic#84293)
  Revert "[Alerting] renames Resolved action group to Recovered (elastic#84123)"
  Update code-comments describing babel plugins (elastic#84622)
  [Security Solution] [Cases] Cypress for case connector selector options (elastic#80745)
  [Discover] Unskip doc table tests (elastic#84564)
  [Lens] (Accessibility) Improve landmarks in Lens (elastic#84511)
  [Lens] (Accessibility) Focus mistakenly stops on righthand form (elastic#84519)
  Return early when parallel install process detected (elastic#84190)
  [Security Solution][Detections] Support arrays in event fields for Severity/Risk overrides (elastic#83723)
  [Security Solution][Detections] Fix grammatical error in validation message for threshold field in "Create new rule" -> "Define rule" (elastic#84490)
  [Fleet] Update agent details page  (elastic#84434)
  adding documentation of use of NODE_EXTRA_CA_CERTS env var (elastic#84578)
  [Search] Integrate "Send to background" UI with session service (elastic#83073)
  ...
gchaps added a commit that referenced this pull request Dec 1, 2020
@gchaps @balooka
Update create.asciidoc (#84046) (#84675)
ea19e4e 
The url templates provided for call of the API with space information 
was missing the /api/ section in it.

(cherry picked from commit 35f1cc16eaa29666d7212402f57ab17858ebc96d)

Co-authored-by: Kibana Machine 
<42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Olivier V <vandamo.be@gmail.com>
gchaps added a commit that referenced this pull request Dec 1, 2020
@gchaps @balooka @kibanamachine
[7.x] Update create.asciidoc (#84046) (#84671)
c5db7ce 
* Update create.asciidoc (#84046)

The url templates provided for call of the API with space information was missing the /api/ section in it.

(cherry picked from commit 35f1cc16eaa29666d7212402f57ab17858ebc96d)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [DOCS] Fixes requests

Co-authored-by: Olivier V <vandamo.be@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gchaps added a commit that referenced this pull request Dec 1, 2020
@gchaps @balooka @kibanamachine
[7.10] Update create.asciidoc (#84046) (#84672)
b817924 
* Update create.asciidoc (#84046)

The url templates provided for call of the API with space information was missing the /api/ section in it.

(cherry picked from commit 35f1cc16eaa29666d7212402f57ab17858ebc96d)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [DOCS] Fixes requests

Co-authored-by: Olivier V <vandamo.be@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gchaps added a commit that referenced this pull request Dec 1, 2020
@gchaps @balooka @kibanamachine
[7.9] Update create.asciidoc (#84046) (#84673)
941c66f 
* Update create.asciidoc (#84046)

The url templates provided for call of the API with space information was missing the /api/ section in it.

(cherry picked from commit 35f1cc16eaa29666d7212402f57ab17858ebc96d)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [DOCS] Fixes requests

Co-authored-by: Olivier V <vandamo.be@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gchaps added a commit that referenced this pull request Dec 1, 2020
@gchaps @balooka @kibanamachine
[7.8] Update create.asciidoc (#84046) (#84674)
eb3813a 
* Update create.asciidoc (#84046)

The url templates provided for call of the API with space information was missing the /api/ section in it.

(cherry picked from commit 35f1cc16eaa29666d7212402f57ab17858ebc96d)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [DOCS] Fixes requests

Co-authored-by: Olivier V <vandamo.be@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@gchaps gchaps removed the v7.6.0 label Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KOTungseth KOTungseth KOTungseth approved these changes

@gchaps gchaps gchaps approved these changes

@legrego legrego legrego approved these changes

Assignees
No one assigned
Labels
💝community release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.7.0 v7.8.0 v7.9.0 v7.10.0 v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@balooka @kibanamachine @elasticmachine @pmuellr @gchaps @legrego @spalger @KOTungseth