-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v30.4.2 #84158
Upgrade EUI to v30.4.2 #84158
Conversation
Pinging @elastic/eui-design (EUI) |
Pinging @elastic/apm-ui (Team:apm) |
Pinging @elastic/ingest-management (Team:Ingest Management) |
Pinging @elastic/uptime (Team:uptime) |
src/plugins/discover/public/application/components/sidebar/discover_field_search.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibana-core-ui changes LGTM
.../public/applications/fleet/sections/agent_policy/components/danger_eui_context_menu_item.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security Solution changes LTGM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ML edit LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KibanaApp changes LGTM - I agree with the assessment on the test of the field search popover.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ingest Manager changes 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apm changes lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uptime changes LGTM !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces changes LGTM. Tested the affected popover locally.
💔 Build Failed
Failed CI StepsTest FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/uptime/alert_flyout·ts.Uptime app with real-world data uptime alerts overview page alert flyout controls can set alert time rangeStandard Out
Stack Trace
Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/uptime/alert_flyout·ts.Uptime app with real-world data uptime alerts overview page alert flyout controls can set alert time rangeStandard Out
Stack Trace
Chrome X-Pack UI Plugin Functional Tests.x-pack/test/plugin_functional/test_suites/global_search/global_search_bar·ts.GlobalSearch API GlobalSearchBar redirects to the correct pageStandard Out
Stack Trace
Metrics [docs]Async chunks
Distributable file count
Page load bundle
Unknown metric groups@kbn/ui-shared-deps asset size
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ES UI changes LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
infra
plugin changes LGTM
Because of a substantial number of changes happening after many of the approvals, I'm closing this in favour of #84677 which continues the upgrade work. |
Summary
NOTE: this PR initially introduced a change where EuiPopover would default to trapping focus, this has been reverted
eui@30.2.0
⏩eui@30.4.2
Changes impacting this upgrade:
htmlIdGenerator
utility for jest environmenttextColors
SCSS variable was renamed toeuiTextColors
Changed EuiPopover's default value for(rolled back in v30.4.2 due to UX regression & introduces a bug in Kibana, see Revert "[EuiPopover] Default to ownFocus (#4228)" eui#4311)ownFocus
from false to true30.4.2
Bug fixes
EuiPopover
sownFocus
default fromfalse
totrue
(#4228)30.4.1
useDataGridColumnSelector
,useDataGridColumnSorting
, anduseDataGridStyleSelector
hooks (#4271)Theme: Amsterdam
EuiButton
(#4284)Bug fixes
EuiDataGrid
leadingControlColumns (#4269)30.4.0
eql
glyph inEuiIcon
(#4110)testenv
mock forhtmlIdGenerator
(#4212)Bug fixes
EuiDataGrid
rightmost header cell (#4071)Theme: Amsterdam
outline
and restricting to keyboard navigation (#4242)EuiAvatar
(#4255)30.3.0
EuiColorPaletteDisplay
component (#3865)initialFocusedItemIndex
support toEuiContextMenuPanelDescriptor
(#4223)EuiPopover
sownFocus
prop fromfalse
totrue
(#4228)role="alert"
andaria-live="assertive"
toEuiForm
'sEuiCallOut
for the errors (#4238)menuDown
andmenuUp
glyphs toEuiIcon
(#4244)childrenBetween
inEuiInMemoryTable
(#4248)clickOutsideDisables
totrue
whenownFocus={false}
inEuiFlyout
(#4236)Bug fixes
EuiPopover
bug which prevented the anchor from receiving focus when the popover closes (#4071)EuiInMemoryTable
to avoid mistaken assignment ofsortName
(#4138)EuiImage
's not respecting the optional sizes whenallowFullScreen
is set to true (#4207)EuiDualRange
thumbs when element width is 0 (#4230)EuiSelectable
to callsearchProps.onChange
andsearchProps.onSearch
calls inEuiSelectable
(#4153)EuiComboBox
placeholder
text (#4210)Theme: Amsterdam
line-heights
for withineuiFontSize[size]()
SASS mixins (#4229)