-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NA): remove scripts on plugins to find circular deps #84852
chore(NA): remove scripts on plugins to find circular deps #84852
Conversation
Pinging @elastic/kibana-operations (Team:Operations) |
Can also remove |
Looks like we were running the script in a couple places... It will also need removed from here. |
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@brianseeders, wanted to confirm with you if you would like us to be making the changes to the Teamcity configs here as well, or if you would rather handle it separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked this over, and if the new tooling does indeed solve the problem of finding circular deps directly within the code base between TypeScript and JS files then we don't need ours anymore. So 👍
@tylersmalley You totally can. In general, for now, I don't mind if you pretend like the |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/uptime/locations·ts.Uptime app with generated data Observer location displays less monitor availabilityStandard Out
Stack Trace
Metrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
7.x: e05fa92 |
…4852) * chore(NA): remove extra scripts on plugins to find circular deps * chore(NA): remove madge as dependency * Move cyclic dep jobs Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # test/scripts/jenkins_xpack.sh # yarn.lock
…85185) * chore(NA): remove extra scripts on plugins to find circular deps * chore(NA): remove madge as dependency * Move cyclic dep jobs Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # test/scripts/jenkins_xpack.sh # yarn.lock
With the merge of #82867 I believe the intended feature for those scripts is also covered on the other tool. As so I'm removing the scripts and the extra CI checks.