chore(NA): add resolution for chokidar to prevent fsevents@1.x #85171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
mistic
changed the title
chokidar to prevent fsevents@1.x
mistic
changed the title
chokidar to prevent fsevents@1.x
spalger
approved these changes
Dec 7, 2020
There was a problem hiding this comment.
Based on the release notes for chokidar 3 it seems we shouldn't have any problems relying on it instead of 2, LGTM
tylersmalley
approved these changes
Dec 7, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
7.x: c3a0e29 |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Dec 10, 2020
…ic#85171) * chore(NA): add fsevents resolution to 2.x * chore(NA): add fsevents as an optionalDepedency to allow resolutions to be set for it * chore(NA): remove fsevents resolution from package.json * chore(NA): remove optionalDependencies from being declared * chore(NA): update kbn pm dist Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
mistic
added a commit
that referenced
this pull request
Dec 10, 2020
… (#85501) * chore(NA): add fsevents resolution to 2.x * chore(NA): add fsevents as an optionalDepedency to allow resolutions to be set for it * chore(NA): remove fsevents resolution from package.json * chore(NA): remove optionalDependencies from being declared * chore(NA): update kbn pm dist Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fsevents 1.xrequires a native module to be built every time yarn install runs which invalidates bazel remote cache as discovered as part of #74105.In order to avoid that in our effort for the future new build tools #69706 we want to prevent this happening with that PR which adds resolutions for
chokidarwho was the package being responsible to install multiple versions offsevents.Currently we cannot add a resolution for
fseventsdue to yarnpkg/yarn#6834 and as yarn is currently not handling it right, due to a bug, setting the resolution will make yarn try to install the optional dependency anyway underlinuxandwindowswhich are not os system not supported forfsevents.