Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Add EuiButtonEmptyTo component #85213

Conversation

scottybollinger
Copy link
Contributor

@scottybollinger scottybollinger commented Dec 8, 2020

Summary

This PR adds another wrapper component for internal routing, the EuiButtonEmptyTo component.

Checklist

This PR adds another wrapper component for internal routing, the EuiButtonEmptyTo component.
@scottybollinger scottybollinger added Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Dec 8, 2020
@scottybollinger scottybollinger requested a review from a team December 8, 2020 00:00
@scottybollinger scottybollinger changed the title [Enterprise Search] Add EuiButtonEmptyTo components [Enterprise Search] Add EuiButtonEmptyTo component Dec 8, 2020
Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks Scotty!!! I think EuiCardTo might be our only/last helper after this, woo!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.7MB 1.7MB +447.0B

Distributable file count

id before after diff
default 46934 47694 +760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger scottybollinger merged commit 62e79ee into elastic:master Dec 8, 2020
@scottybollinger scottybollinger deleted the scottybollinger/eui-empty-button-helper branch December 8, 2020 03:03
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 8, 2020
…or-disable-searchable-snapshot-fields

* 'master' of github.com:elastic/kibana: (29 commits)
  HTTP CRUD+ API for Index Patterns (elastic#83576)
  Don't list packages in devDependencies already listed in dependencies (elastic#85120)
  Remove unused devDependencies (elastic#85121)
  [ILM] Reposition form toggles (elastic#85143)
  [APM] Make sure jest script can be run from anywhere (elastic#85111)
  Add EuiButtonEmptyTo components (elastic#85213)
  skip flaky suite (elastic#85216)
  skip flaky suite (elastic#83775)
  skip flaky suite (elastic#83774)
  skip flaky suite (elastic#83773)
  skip flaky suite (elastic#83793)
  skip flaky suite (elastic#85215)
  skip flaky suite (elastic#85217)
  [Usage Collection] Kibana Overview Page UI Metrics (elastic#81937)
  [Alerting UI] Replaced AlertsContextProvider with KibanaContextProvider and exposed components in API (elastic#84604)
  skip flaky suite (elastic#85208)
  [Security Solutions][Detection Engine] Fixes cypress errors by using latest signals mapping (elastic#84600)
  Small fixes to Kibana search bar (elastic#85079)
  Change link text to say Fleet (elastic#85083)
  [Metrics UI] Refactor Process List API to fetch only top processes (elastic#84716)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx
@cee-chen
Copy link
Contributor

cee-chen commented Dec 8, 2020

@scottybollinger Do you mind backporting this to 7.x as well so App Search can use this? 🙇‍♀️

@scottybollinger
Copy link
Contributor Author

Just did. Got this yesterday or it would have been done already:

 Cherry-picking: Add EuiButtonEmptyTo components (#85213)
 Pushing branch "scottybollinger:backport/7.x/pr-85213"
 Creating pull request
Could not create pull request: API rate limit exceeded for user ID 1869731.

scottybollinger added a commit to scottybollinger/kibana that referenced this pull request Dec 8, 2020
This PR adds another wrapper component for internal routing, the EuiButtonEmptyTo component.
@cee-chen
Copy link
Contributor

cee-chen commented Dec 8, 2020

Whoa!! Interesting, never seen that before... Scotty, you DDoSing GitHub again??

scottybollinger added a commit that referenced this pull request Dec 8, 2020
This PR adds another wrapper component for internal routing, the EuiButtonEmptyTo component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants