Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.10] Bump highlight.js to v9.18.5 (#84296) #85369

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

jportner
Copy link
Contributor

@jportner jportner commented Dec 9, 2020

Backports the following commits to 7.10:

@jportner
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@jportner jportner force-pushed the backport/7.10/pr-84296 branch from 524eeb0 to 1b0c635 Compare December 14, 2020 20:53
* Remove APM stacktrace snapshots

These are not necessary and have caused problems for other contributors. Replace the snapshots with tests that check for errors or the structure of the results.

Move the test files out of the __test__ directory and rename the directory to __fixtures__.
@jportner
Copy link
Contributor Author

Note, I had to manually add a backport commit of another PR (058fcdb) so Jest tests would pass. That PR was only backported to 7.11, not 7.10.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1270 1648 +378

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.2MB 5.6MB ⚠️ +1.4MB
enterpriseSearch 649.4KB 649.5KB +96.0B
total ⚠️ +1.4MB

Distributable file count

id before after diff
default 48788 48802 +14
oss 29135 29149 +14

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 48.3KB 48.3KB +8.0B
upgradeAssistant 64.5KB 64.6KB +96.0B
total +104.0B
Unknown metric groups

@kbn/ui-shared-deps asset size

id before after diff
kbn-ui-shared-deps.@elastic.js 3.1MB 3.1MB +5.0B
kbn-ui-shared-deps.js 4.7MB 4.8MB +47.8KB
total +47.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner merged commit 6f7ab30 into elastic:7.10 Dec 15, 2020
@jportner jportner deleted the backport/7.10/pr-84296 branch December 15, 2020 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants