Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Unskip tests and make sure submit is not triggered too quickly #85567

Merged
merged 2 commits into from
Dec 14, 2020
Merged

[Lens] Unskip tests and make sure submit is not triggered too quickly #85567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37c18bb
unskip tests and make sure submit is not triggered too quickly
flash1293 Dec 10, 2020
a617b1b
Merge branch 'master' into lens/fix-flaky-popovers
kibanamachine Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s/public/indexpattern_datasource/operations/definitions/shared_components/label_input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const LabelInput = ({
inputRef.current = node;
}
}}
onKeyDown={({ key }: React.KeyboardEvent<HTMLInputElement>) => {
onKeyUp={({ key }: React.KeyboardEvent<HTMLInputElement>) => {
if (keys.ENTER === key && onSubmit) {
onSubmit();
}
Expand Down
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/lens/smokescreen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const listingTable = getService('listingTable');
const testSubjects = getService('testSubjects');

// FLAKY: https://github.com/elastic/kibana/issues/77969
describe.skip('lens smokescreen tests', () => {
describe('lens smokescreen tests', () => {
it('should allow creation of lens xy chart', async () => {
await PageObjects.visualize.navigateToNewVisualization();
await PageObjects.visualize.clickVisType('lens');
Expand Down