[Maps] Track enterprise use of on-prem EMS #85885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
chore
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
thomasneirynck
commented
Dec 14, 2020
| @@ -39,10 +39,6 @@ export class EMSSettings { | |||
| return this._config.emsUrl!.replace(/\/$/, ''); | |||
| } | |||
|
|
|||
| isOnPrem(): boolean { | |||
There was a problem hiding this comment.
this is cruft, and unused.
nickpeihl
reviewed
Dec 15, 2020
| @@ -39,10 +39,6 @@ export class EMSSettings { | |||
| return this._config.emsUrl!.replace(/\/$/, ''); | |||
| } | |||
|
|
|||
| isOnPrem(): boolean { | |||
x-pack/plugins/maps/public/classes/layers/vector_tile_layer/vector_tile_layer.js
Show resolved
Hide resolved
nickpeihl
approved these changes
Dec 15, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Dec 15, 2020
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Dec 15, 2020
thomasneirynck
added a commit
that referenced
this pull request
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Blocked by #85729 and #85807. Those PRs have some code-changes that will cause merge-conflicts.Track usage of on-prem EMS layers with the notifyUsage API.
(btw. I understand the irony, but for completeness sake).