Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Add Pinned Event tabs on Timeline #85905

Merged
merged 30 commits into from
Dec 16, 2020
Merged

[Security Solution] Add Pinned Event tabs on Timeline #85905

merged 30 commits into from
Dec 16, 2020

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Dec 15, 2020 •
edited
Loading

Summary

Add Pinned Events in timeline

image

@XavierM XavierM added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 Team:Threat Hunting Security Solution Threat Hunting Team labels Dec 15, 2020
@XavierM XavierM self-assigned this Dec 15, 2020
@XavierM XavierM requested review from a team as code owners December 15, 2020 05:02
@XavierM XavierM added the Feature:Timeline Security Solution Timeline feature label Dec 15, 2020
@angorayc
Copy link
Contributor

@elasticmachine merge upstream

@angorayc angorayc mentioned this pull request Dec 15, 2020
Merged
@angorayc
Copy link
Contributor

@elasticmachine merge upstream

@andrew-goldstein
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@cnasikas
Copy link
Member

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@elastic elastic deleted a comment from kibanamachine Dec 16, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2163 2164 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB +22.4KB

Distributable file count

id before after diff
default 47280 48043 +763
Unknown metric groups

async chunk count

id before after diff
securitySolution 23 24 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc merged commit 0586c06 into elastic:master Dec 16, 2020
angorayc added a commit to angorayc/kibana that referenced this pull request Dec 16, 2020
@XavierM @kibanamachine
@cnasikas @angorayc
[Security Solution] Add Pinned Event tabs on Timeline (elastic#85905)
a0eee2e 
* wip

* finish drag & drop from pinned events + fix top n

* Fix types

* update cypress

* Fix unit tests

* fix cypress test

* fix filter out/in

* remove unused components

* fix pagination cypress test

* cypress timelines selectors

* review and skip cypress test

* more to skip

* fix type

* skip case

* Fix types

* Fix tests

* skip resolver

* only query pinned events

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>
@angorayc angorayc mentioned this pull request Dec 16, 2020
Merged
angorayc added a commit to angorayc/kibana that referenced this pull request Dec 16, 2020
@XavierM @kibanamachine
@cnasikas @angorayc
[Security Solution] Add Pinned Event tabs on Timeline (elastic#85905)
20a314c 
* wip

* finish drag & drop from pinned events + fix top n

* Fix types

* update cypress

* Fix unit tests

* fix cypress test

* fix filter out/in

* remove unused components

* fix pagination cypress test

* cypress timelines selectors

* review and skip cypress test

* more to skip

* fix type

* skip case

* Fix types

* Fix tests

* skip resolver

* only query pinned events

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>
@angorayc angorayc mentioned this pull request Dec 16, 2020
Merged
XavierM added a commit that referenced this pull request Dec 17, 2020
@angorayc @XavierM
@kibanamachine @cnasikas
[Security Solution] Add Pinned Event tabs on Timeline (#85905) (#86159)
f041891 
* wip

* finish drag & drop from pinned events + fix top n

* Fix types

* update cypress

* Fix unit tests

* fix cypress test

* fix filter out/in

* remove unused components

* fix pagination cypress test

* cypress timelines selectors

* review and skip cypress test

* more to skip

* fix type

* skip case

* Fix types

* Fix tests

* skip resolver

* only query pinned events

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
XavierM added a commit that referenced this pull request Dec 17, 2020
@angorayc @XavierM
@kibanamachine @cnasikas
[Security Solution] Add Pinned Event tabs on Timeline (#85905) (#86161)
79964db 
* wip

* finish drag & drop from pinned events + fix top n

* Fix types

* update cypress

* Fix unit tests

* fix cypress test

* fix filter out/in

* remove unused components

* fix pagination cypress test

* cypress timelines selectors

* review and skip cypress test

* more to skip

* fix type

* skip case

* Fix types

* Fix tests

* skip resolver

* only query pinned events

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
@andrew-goldstein andrew-goldstein mentioned this pull request Mar 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees

@XavierM XavierM

Labels
Feature:Timeline Security Solution Timeline feature release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XavierM @angorayc @andrew-goldstein @kibanamachine @cnasikas