Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audit events for spaces #86343

Merged
merged 2 commits into from
Dec 18, 2020
Merged

Conversation

thomheymann
Copy link
Contributor

Summary

Adds audit events for spaces CRUD operations.

Checklist

Delete any items that are not applicable to this PR.

@@ -89,9 +88,12 @@ Refer to the corresponding {es} logs for potential write errors.
| `failure` | User is not authorized to create a connector.

.2+| `alert_create`
| `unknown` | User is creating an alert rule.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really part of this PR but decided to fix the docs for these since we went with "alert_" rather than "alert_rule_" in the end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We unfortunately can't backport this PR to 7.11, so we'll need another PR to update the 7.11 version of the docs for alerts

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47280 48040 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego added v7.12.0 Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! and removed v7.11.0 labels Dec 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego added the Feature:Security/Audit Platform Security - Audit Logging feature label Dec 18, 2020
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested locally. Thanks!

@@ -89,9 +88,12 @@ Refer to the corresponding {es} logs for potential write errors.
| `failure` | User is not authorized to create a connector.

.2+| `alert_create`
| `unknown` | User is creating an alert rule.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We unfortunately can't backport this PR to 7.11, so we'll need another PR to update the 7.11 version of the docs for alerts

@thomheymann thomheymann merged commit e65c533 into elastic:master Dec 18, 2020
thomheymann added a commit to thomheymann/kibana that referenced this pull request Dec 21, 2020
* Add audit events for spaces

* fix eslint error
thomheymann added a commit that referenced this pull request Dec 21, 2020
* Add audit events for spaces

* fix eslint error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Security/Audit Platform Security - Audit Logging feature release_note:enhancement Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants