Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Add range query to service map trace walk #86631

Merged
merged 5 commits into from
Jan 4, 2021

Conversation

dgieselaar
Copy link
Member

Adds an +-1d offset to the service map query that fetches & walks traces. This allows ES to skip indices that will have no matches. Hopefully this will resolve some of the performance issues.

Creates an edge-case where long-running traces cannot be properly inspected (e.g., a trace that started well before the current time range), but that seems unlikely and worth the trade-off.

@dgieselaar dgieselaar added Team:APM All issues that need APM UI Team support v7.11.0 labels Dec 21, 2020
@dgieselaar dgieselaar requested a review from a team as a code owner December 21, 2020 11:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

traceIds: string[]
) {
const { apmEventClient } = setup;

// make sure there's a range so ES can skip shards
const day = 24 * 60 * 60 * 1000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const day = 24 * 60 * 60 * 1000;
const dayAsMilliseconds = 24 * 60 * 60 * 1000;

Comment on lines 41 to 43
{
range: rangeFilter(start, end),
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
range: rangeFilter(start, end),
},
{ range: rangeFilter(start, end), },

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits

@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

kibanamachine and others added 4 commits December 29, 2020 03:06

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47264 48024 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit 1934d34 into elastic:master Jan 4, 2021
@dgieselaar dgieselaar deleted the service-map-range-query branch January 4, 2021 10:37
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Jan 4, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Jan 4, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dgieselaar added a commit that referenced this pull request Jan 4, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 4, 2021

Verified

This commit was signed with the committer’s verified signature.
jloleysens Jean-Louis Leysens
…meline-component

* 'master' of github.com:elastic/kibana: (955 commits)
  remove SameSite:None workaround (elastic#86994)
  URL encoding for URL drilldown (elastic#86902)
  [Security Solution] Fix few styling issues (elastic#87045)
  [APM] Custom links can still be created with a read only user. (elastic#87089)
  prevent double update (elastic#86794)
  Upgrade @hapi/hoek to revert hack introduced in hapi v20 upgrade (elastic#87113)
  [APM] Every time the new Header Icon is clicked it fetches data (elastic#87093)
  [APM] Add range query to service map trace walk (elastic#86631)
  [Discover] Deangularize navbar in context app (elastic#86353)
  skip "should schedule actions on legacy alerts" elastic#87010
  🍾 update notice text for 2021
  [logstash] remove "upgrade" functionality now that .logstash is a system index (elastic#87056)
  Enable prototype pollution protection in TSVB (elastic#85952)
  [Security Solution] add a consistent spelling of ES in Policy Response (elastic#87073)
  [SECURITY_SOLUTION][ENDPOINT] Delete Endpoint Policy List code (elastic#87063)
  Adds more URLs to the docs links service (elastic#86972)
  Add missing backticks in reporting-settings.asciidoc (elastic#77979)
  [test/functional_cors] 9000 is sometimes in use, make getPort random (elastic#87050)
  [Security Solution] Fix Timeline filter EuiSuperSelect styling (elastic#87033)
  [Lens] Fix duplicate suggestions on single-bucket charts (elastic#86996)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/index.ts
dgieselaar added a commit that referenced this pull request Jan 5, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants