Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] URL encoding for URL drilldown (#86902) #87143

Merged
merged 4 commits into from
Jan 5, 2021
Merged

[7.x] URL encoding for URL drilldown (#86902) #87143

merged 4 commits into from
Jan 5, 2021

Conversation

streamich
Copy link
Contributor

Backports the following commits to 7.x:

* feat: 🎸 use EuiSwitch for "Open in new window" toggle

* feat: 🎸 add "URL encoding" option and "Additional options"

* feat: 🎸 make "Open in new window" true by default

* feat: 🎸 respect encoding config setting

* test: 💍 add encoding tests

* feat: 🎸 add URI encoding Handlebars helpers

* docs: ✏️ add URL encoding methods to URL Drilldown docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -26.9KB

Distributable file count

id before after diff
default 47592 48355 +763

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 162.5KB 162.6KB +102.0B
uiActionsEnhanced 267.6KB 270.2KB +2.6KB
urlDrilldown 53.9KB 54.1KB +155.0B
total +2.9KB
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit 98485a5 into elastic:7.x Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants