-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task Manager] adds more granular polling results to monitoring stats #87494
Conversation
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM and looks very clear! To which issue this changes related?
Thanks Yul, it's something I'm adding because of the ongoing perf tests, but it doesn't resolve any issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…elastic#87494) Added the following values to the Polling stats: - **NoAvailableWorkers**: This tells us when a polling cycle resulted in no tasks being claimed due to there being no available workers - **RunningAtCapacity**: This tells us when a polling cycle resulted in tasks being claimed at 100% capacity of the available workers - **Failed**: This tells us when the poller failed to claim
…elastic#87494) Added the following values to the Polling stats: - **NoAvailableWorkers**: This tells us when a polling cycle resulted in no tasks being claimed due to there being no available workers - **RunningAtCapacity**: This tells us when a polling cycle resulted in tasks being claimed at 100% capacity of the available workers - **Failed**: This tells us when the poller failed to claim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…#87494) (#87539) Added the following values to the Polling stats: - **NoAvailableWorkers**: This tells us when a polling cycle resulted in no tasks being claimed due to there being no available workers - **RunningAtCapacity**: This tells us when a polling cycle resulted in tasks being claimed at 100% capacity of the available workers - **Failed**: This tells us when the poller failed to claim
…#87494) (#87540) Added the following values to the Polling stats: - **NoAvailableWorkers**: This tells us when a polling cycle resulted in no tasks being claimed due to there being no available workers - **RunningAtCapacity**: This tells us when a polling cycle resulted in tasks being claimed at 100% capacity of the available workers - **Failed**: This tells us when the poller failed to claim
Summary
Added the following values to the Polling stats:
Adding these to aid with #40264
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportAny UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)This was checked for cross-browser compatibilityFor maintainers