Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Unskip "Observer location" test block #87571

Merged
merged 6 commits into from
Jan 15, 2021
Merged

[Uptime] Unskip "Observer location" test block #87571

merged 6 commits into from
Jan 15, 2021

Conversation

justinkambic
Copy link
Contributor

Summary

Resolves #85208.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience test_xpack_functional v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v7.12.0 labels Jan 6, 2021
@justinkambic justinkambic self-assigned this Jan 6, 2021
@justinkambic justinkambic mentioned this pull request Jan 13, 2021
Merged
8 tasks
@justinkambic
Copy link
Contributor Author

justinkambic commented Jan 13, 2021 •
edited
Loading

I have now run 3 flaky test builds without this test suite failing. I just kicked off a fourth. If it also succeeds, I'll open the PR for review.

This patch has now passed four flaky test builds without failing, I think it's ok to review it now.

https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1096/
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1099/
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1102/
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1105/

@justinkambic justinkambic requested review from mistic and a team January 13, 2021 18:38
@justinkambic justinkambic marked this pull request as ready for review January 13, 2021 18:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@justinkambic justinkambic added the release_note:skip Skip the PR/issue when compiling release notes label Jan 13, 2021
@justinkambic
Copy link
Contributor Author

@elastic/uptime @mistic I think this should be ready for a review.

dominiqueclarke
dominiqueclarke approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 1.1MB 1.1MB +248.0B

History

  • 💚 Build #98568 succeeded 04d25ea02797cac60c10ce99b657bf2bc5d69f4f
  • 💚 Build #98451 succeeded 00f12baa661f42e14b36108eadb65f46a85bfc49
  • 💔 Build #98192 failed f45041355755d17020535a2f3bc87d4a0960e82e
  • 💔 Build #98107 failed 87dacdf6ecbd303cad77dadcce3dc4acdd61901c
  • 💔 Build #97423 failed c5d55dbf464832b85c4a28cae26529956529466d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mistic
mistic approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinkambic justinkambic merged commit fc370b7 into elastic:master Jan 15, 2021
@justinkambic justinkambic mentioned this pull request Jan 15, 2021
Merged
@justinkambic justinkambic mentioned this pull request Jan 15, 2021
Merged
justinkambic added a commit to justinkambic/kibana that referenced this pull request Jan 15, 2021
@justinkambic
[Uptime] Unskip "Observer location" test block (elastic#87571)
5db59e0 
* Unskip "Observer location" test block.

* Commit temp "describe.only" to make flaky test runner go faster.

* Add optional chain for some potentially-null props.

* Make overview filters type partial.

* Repair broken types.

* Remove \`only\` call from test.
justinkambic added a commit that referenced this pull request Jan 15, 2021
@justinkambic
[Uptime] Unskip "Observer location" test block (#87571) (#88478)
341e103 
* Unskip "Observer location" test block.

* Commit temp "describe.only" to make flaky test runner go faster.

* Add optional chain for some potentially-null props.

* Make overview filters type partial.

* Repair broken types.

* Remove \`only\` call from test.
justinkambic added a commit that referenced this pull request Jan 15, 2021
@justinkambic
[Uptime] Unskip "Observer location" test block (#87571) (#88479)
ec0de48 
* Unskip "Observer location" test block.

* Commit temp "describe.only" to make flaky test runner go faster.

* Add optional chain for some potentially-null props.

* Make overview filters type partial.

* Repair broken types.

* Remove \`only\` call from test.
@justinkambic
Copy link
Contributor Author

Backported to:

@justinkambic justinkambic deleted the 85208 branch January 15, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@mistic mistic mistic approved these changes

Assignees

@justinkambic justinkambic

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test_xpack_functional v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@justinkambic @elasticmachine @kibanamachine @mistic @dominiqueclarke