Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX] move some ES UI plugins to TS project #88050

Merged
merged 7 commits into from
Jan 13, 2021
Merged

[DX] move some ES UI plugins to TS project #88050

merged 7 commits into from
Jan 13, 2021

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Jan 12, 2021 •
edited
Loading

Summary

Part of #80508
Move to TS projects:

  • es_ui_shared
  • console
  • console_extensions
  • searchprofiler

@mshustov mshustov added chore release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 12, 2021
@mshustov mshustov requested a review from a team as a code owner January 12, 2021 17:00
@mshustov mshustov mentioned this pull request Jan 12, 2021
Closed
@smith smith mentioned this pull request Jan 13, 2021
Closed
alisonelizabeth
alisonelizabeth approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. I built each plugin locally using ./node_modules/.bin/tsc -b src/plugins/my_plugin and everything was successful. I did not measure the tsc compiler performance. Thanks for working on this @restrry!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit 5814ca6 into elastic:master Jan 13, 2021
@mshustov mshustov deleted the es-ui-ts-project branch January 13, 2021 20:58
@mshustov mshustov mentioned this pull request Jan 13, 2021
Merged
mshustov added a commit that referenced this pull request Jan 14, 2021
@mshustov
[DX] move some ES UI plugins to TS project (#88050) (#88276)
4b650e9 
* es_ui_shared to ts project

* console to ts project

* console_extensions to ts project

* searchprofiler to ts project

* update includes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@cjcenizal cjcenizal Awaiting requested review from cjcenizal

Assignees
No one assigned
Labels
backported chore release_note:skip Skip the PR/issue when compiling release notes v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshustov @kibanamachine @alisonelizabeth