Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Add smoke test for lens in canvas #88657

Merged
merged 11 commits into from
Feb 1, 2021
Merged

[Lens] Add smoke test for lens in canvas #88657

merged 11 commits into from
Feb 1, 2021

Conversation

flash1293
Copy link
Contributor

Part of #72585

This adds a simple smoke test for a lens vis embedded in canvas.

To do so, the canvas role requires access to visualize features as well.

@flash1293 flash1293 added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.12.0 8.0.0 labels Jan 19, 2021
@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review January 20, 2021 12:37
@flash1293 flash1293 requested a review from a team as a code owner January 20, 2021 12:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@wylieconlon wylieconlon added v8.0.0 and removed 8.0.0 labels Jan 20, 2021
@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

clintandrewhall
clintandrewhall approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@clintandrewhall clintandrewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... but skipping firefox? Is that a standard thing?

x-pack/test/functional/apps/canvas/lens.ts Outdated
const esArchiver = getService('esArchiver');

describe('lens in canvas', function () {
this.tags('skipFirefox');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skip firefox?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several of our canvas tests skip firefox due to some weird behavior where the browser refuses to detect elements that actually exist and causes flakiness

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just copied it over from there. I will give it a try and see whether everything works for this specific test.

wylieconlon
wylieconlon approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't run the tests locally but I have no objections to this, just left a comment about the archive handling.

x-pack/test/functional/apps/canvas/lens.ts

describe('lens in canvas', function () {
before(async () => {
await esArchiver.load('canvas/lens');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be loadIfNeeded and have an after with unload?

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit e31b6a8 into elastic:master Feb 1, 2021
flash1293 added a commit to flash1293/kibana that referenced this pull request Feb 1, 2021
@flash1293
[Lens] Add smoke test for lens in canvas (elastic#88657)
3c2b2cf
@flash1293 flash1293 mentioned this pull request Feb 1, 2021
Merged
flash1293 added a commit that referenced this pull request Feb 1, 2021
@flash1293
[Lens] Add smoke test for lens in canvas (#88657) (#89845)
9dab264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poffdeluxe poffdeluxe poffdeluxe left review comments

@wylieconlon wylieconlon wylieconlon approved these changes

@clintandrewhall clintandrewhall clintandrewhall approved these changes

Assignees
No one assigned
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@flash1293 @elasticmachine @kibanamachine @clintandrewhall @wylieconlon @poffdeluxe