Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Add drag drop tests #88660

Merged
merged 4 commits into from
Jan 25, 2021
Merged

[Lens] Add drag drop tests #88660

merged 4 commits into from
Jan 25, 2021

Conversation

flash1293
Copy link
Contributor

Part of #72585

This PR adds tests validating the behavior for dragging a field into the workspace

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.12.0 8.0.0 labels Jan 19, 2021
@flash1293 flash1293 marked this pull request as ready for review January 19, 2021 14:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@wylieconlon wylieconlon added v8.0.0 and removed 8.0.0 labels Jan 20, 2021
@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

stratoula
stratoula approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I run it locally, works fine 🙂

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 02f24de into elastic:master Jan 25, 2021
flash1293 added a commit to flash1293/kibana that referenced this pull request Jan 25, 2021
@flash1293
[Lens] Add drag drop tests (elastic#88660)
ce41111
@flash1293 flash1293 mentioned this pull request Jan 25, 2021
Merged
flash1293 added a commit that referenced this pull request Jan 25, 2021
@flash1293
[Lens] Add drag drop tests (#88660) (#89100)
0eee355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@flash1293 @elasticmachine @kibanamachine @dej611 @stratoula @wylieconlon