[Lens] Fix indexpattern checks for missing references

x-pack/plugins/lens/public/indexpattern_datasource/indexpattern.tsx

@@ -367,11 +367,14 @@ export function getIndexPatternDatasource({
         return;
       }
 
+      // Forward the indexpattern as well, as it is required by some operationType checks
       const layerErrors = Object.values(state.layers).map((layer) =>
-        (getErrorMessages(layer) ?? []).map((message) => ({
-          shortMessage: '', // Not displayed currently
-          longMessage: message,
-        }))
+        (getErrorMessages(layer, state.indexPatterns[layer.indexPatternId]) ?? []).map(
+          (message) => ({
+            shortMessage: '', // Not displayed currently
+            longMessage: message,
+          })
+        )
       );
 
       // Single layer case, no need to explain more

x-pack/plugins/lens/public/indexpattern_datasource/operations/layer_helpers.test.ts

@@ -2203,5 +2203,33 @@ describe('state_helpers', () => {
 
       delete operationDefinitionMap.testIncompleteReference;
     });
+
+    it('should forward the indexpattern when available', () => {
+      const mock = jest.fn();
+      operationDefinitionMap.testReference.getErrorMessage = mock;
+      getErrorMessages(
+        {
+          indexPatternId: '1',
+          columnOrder: [],
+          columns: {
+            col1:
+              // @ts-expect-error not statically analyzed
+              { operationType: 'testReference', references: [] },
+          },
+        },
+        indexPattern
+      );
+      expect(mock).toHaveBeenCalledWith(
+        {
+          indexPatternId: '1',
+          columnOrder: [],
+          columns: {
+            col1: { operationType: 'testReference', references: [] },
+          },
+        },
+        'col1',
+        indexPattern
+      );
+    });
   });
 });

x-pack/plugins/lens/public/indexpattern_datasource/operations/layer_helpers.ts

@@ -864,18 +864,24 @@ export function updateLayerIndexPattern(
  * - All column references are valid
  * - All prerequisites are met
  */
-export function getErrorMessages(layer: IndexPatternLayer): string[] | undefined {
-  const errors: string[] = [];
-  Object.entries(layer.columns).forEach(([columnId, column]) => {
-    // If we're transitioning to another operation, check for "new" incompleteColumns rather
-    // than "old" saved operation on the layer
-    const columnFinalRef =
-      layer.incompleteColumns?.[columnId]?.operationType || column.operationType;
-    const def = operationDefinitionMap[columnFinalRef];
-    if (def.getErrorMessage) {
-      errors.push(...(def.getErrorMessage(layer, columnId) ?? []));
-    }
-  });
+export function getErrorMessages(
+  layer: IndexPatternLayer,
+  indexPattern?: IndexPattern
+): string[] | undefined {
+  const errors: string[] = Object.entries(layer.columns)
+    .flatMap(([columnId, column]) => {
+      // If we're transitioning to another operation, check for "new" incompleteColumns rather
+      // than "old" saved operation on the layer
+      const columnFinalRef =
+        layer.incompleteColumns?.[columnId]?.operationType || column.operationType;
+      const def = operationDefinitionMap[columnFinalRef];
+
+      if (def.getErrorMessage) {
+        return def.getErrorMessage(layer, columnId, indexPattern);
+      }
+    })
+    // remove the undefined values
+    .filter((v: string | undefined): v is string => v != null);
 
   return errors.length ? errors : undefined;
 }