Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip snapshot_restore API integration tests in cloud #88841

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Skip snapshot_restore API integration tests in cloud #88841

merged 1 commit into from
Jan 20, 2021

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Jan 20, 2021

Summary

This PR disables the snapshot restore API integration tests in cloud.

Details

The shared file system repository that is used during this test suite is not supported in cloud deployments. I've double checked that with Cloud folks on slack.

Closes #86522

@pheyos pheyos added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes test-api-integration v7.11.0 v7.12.0 labels Jan 20, 2021
@pheyos pheyos self-assigned this Jan 20, 2021
@alisonelizabeth alisonelizabeth added Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jan 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

alisonelizabeth
alisonelizabeth approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @pheyos!

I think this fix is OK for now. In the future, I think it would be beneficial to understand if we can still test the API on cloud using a different repository. /cc @cuff-links

@pheyos
Copy link
Member Author

pheyos commented Jan 20, 2021 •
edited
Loading

I think it would be beneficial to understand if we can still test the API on cloud using a different repository.

@alisonelizabeth I agree. But this will probably require some more planning because AFAIK the available repository type(s) depend on the cloud provider - and we want our tests to pass independent of the cloud provider. E.g. in an AWS deployment I think we only have AWS-S3 repositories available, but in a Google cloud deployment I think we go with the GCS repository type by default. Not sure about Azure.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pheyos pheyos merged commit c702b5c into elastic:master Jan 20, 2021
@pheyos pheyos deleted the skip_snapshot_tests_in_cloud branch January 20, 2021 16:30
@pheyos pheyos mentioned this pull request Jan 20, 2021
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Jan 20, 2021
@pheyos
Skip snapshot_restore API integration tests in cloud (elastic#88841)
99367bc 
This PR disables the snapshot restore API integration tests in cloud.
@pheyos pheyos mentioned this pull request Jan 20, 2021
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Jan 20, 2021
@pheyos
Skip snapshot_restore API integration tests in cloud (elastic#88841)
b50de28 
This PR disables the snapshot restore API integration tests in cloud.
pheyos added a commit that referenced this pull request Jan 21, 2021
@pheyos
Skip snapshot_restore API integration tests in cloud (#88841) (#88859)
3c4d152 
This PR disables the snapshot restore API integration tests in cloud.
pheyos added a commit that referenced this pull request Jan 21, 2021
@pheyos
Skip snapshot_restore API integration tests in cloud (#88841) (#88858)
2ad5813 
This PR disables the snapshot restore API integration tests in cloud.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees

@pheyos pheyos

Labels
Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI NeededFor:Cloud release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test-api-integration v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@pheyos @elasticmachine @kibanamachine @alisonelizabeth @cjcenizal