Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Functional tests] Drop legacyEs usage #88939

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Conversation

afharo
Copy link
Member

@afharo afharo commented Jan 21, 2021

Summary

Apparently, #88720 and #80945 happened concurrently and one more usage of legacyEs was introduced.

This PR replaces the use of the service legacyEs in favour of the new es.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 21, 2021
@afharo afharo requested review from jportner and a team January 21, 2021 09:40
@afharo afharo self-assigned this Jan 21, 2021
@afharo
Copy link
Member Author

afharo commented Jan 21, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit 07002d6 into elastic:master Jan 21, 2021
@afharo afharo deleted the ftr/drop-legacyEs branch January 21, 2021 14:49
@afharo
Copy link
Member Author

afharo commented Jan 21, 2021

Can't backport until #88917 is merged

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 22, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 88939 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 25, 2021
afharo added a commit that referenced this pull request Jan 25, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants