[APM] Break down transaction table api removing the sparklines

[cauemarcondes]

closes #88938

To dos:

• Remove sparkline timeseries from API, the avg values must stay because it should be sortable on the table.
• Remove pagination from API
• Create a new API that returns the sparkline timeseries based on the service names received as property

/api/apm/services/opbeans-java/transactions/groups/primary_statistics:

{
   "transactionGroups":[
      {
         "name":"DispatcherServlet#doGet",
         "transactionType":"request",
         "latency":{
            "value":2293337.6551724137
         },
         "throughput":{
            "value":1.933331185187572
         },
         "errorRate":{
            "value":0.06896551724137931
         },
         "impact":null
      }
   ],
   "totalTransactionGroups":1,
   "isAggregationAccurate":true
}

/api/apm/services/opbeans-java/transactions/groups/comparison_statistics:

{
   "DispatcherServlet#doGet":{
      "latency":{
         "timeseries":[
            {
               "x":1611565320000,
               "y":42067.8
            },
            ...
         ]
      },
      "throughput":{
         "timeseries":[
            {
               "x":1611565320000,
               "y":0.3333329629633745
            },
            ...
         ]
      },
      "errorRate":{
         "timeseries":[
            {
               "x":1611565320000,
               "y":0
            },
            ...
         ]
      }
   }
}

transactions.table.mov

[elasticmachine]

Pinging @elastic/apm-ui (Team:apm)

[smith]

Works well.

[dgieselaar]

There's now a bug where comparison data is not refetched if the UI filters change or the latency aggregation type changes. Requesting changes to make sure this is not accidentally merged.

[cauemarcondes]

There's now a bug where comparison data is not refetched if the UI filters change or the latency aggregation type changes. Requesting changes to make sure this is not accidentally merged.

I see now a real reason of having the requesId, if you change the latencyAggregationType and the same list of transaction is returned the comparison statistics won't be refetched. Adding it back, and fixing the bug.

[elasticmachine]

Pinging @elastic/uptime (Team:uptime)

[cauemarcondes]

@dgieselaar I just fixed the bug.

primary-comparison-stats.mov

[sorenlouv]

This file is getting quite big. It might help if you extract the data fetching, including some of the pagination logic eg:

const {
    currentPagePrimaryStatistics,
    primaryStatisticsStatus,
    totalCount,
    requestId,
  } = usePrimaryStatisticsFetcher({ serviceName, pageIndex, sort });

You can do the same with the comparison statistics

[sorenlouv]

lgtm. I can't reproduce the bug that @dgieselaar found previously.

[shahzad31]

UX App, only tests for useFetcher are updated, LGTM !!

@cauemarcondes any idea why that hook needs requestId now?

[dgieselaar]

@elasticmachine merge upstream

[dgieselaar]

I've reverted both requestId changes - the way it was implemented was that requestId would change whenever a new request starts. The previous implementation was that it would only change when a new request ends. I've also added support for transaction duration metrics. Once CI is green I'll merge.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: f7d2157

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
apm	1730	1731	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
apm	5.2MB	5.2MB	+2.0KB

History

• 💚 Build #105478 succeeded e90fa6c
• 💚 Build #105292 succeeded 90ccb07
• 💛 Build #105038 was flaky b15cb64
• 💔 Build #104826 failed b15cb64
• 💛 Build #104771 was flaky a67632f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

Backport result

{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"meta":{"labels":["Team:apm","Team:uptime","apm:comparison","auto-backport","release_note:enhancement","v7.12.0"],"branchLabelMapping":{"^v8.0.0$":"master","^v7.12.0$":"7.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"},"existingTargetPullRequests":[]},"level":"info","message":"Inputs when calculating target branches:"}
{"meta":["7.x"],"level":"info","message":"Target branches inferred from labels:"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm kibanamachine","stdout":"","stderr":"error: No such remote: 'kibanamachine'\n"},"level":"info","message":"exec error 'git remote rm kibanamachine':"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm elastic","stdout":"","stderr":"error: No such remote: 'elastic'\n"},"level":"info","message":"exec error 'git remote rm elastic':"}
{"level":"info","message":"Backporting [{\"sourceBranch\":\"master\",\"targetBranchesFromLabels\":[\"7.x\"],\"sha\":\"2fcf2a91cc870c4dfe52d1107885cefb40e0100e\",\"formattedMessage\":\"[APM] Break down transaction table api removing the sparklines (#88946)\",\"originalMessage\":\"[APM] Break down transaction table api removing the sparklines (#88946)\\n\\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\\r\\nCo-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>\",\"pullNumber\":88946,\"existingTargetPullRequests\":[]}] to 7.x"}

Backporting to 7.x:
{"level":"info","message":"Backporting via filesystem"}
{"level":"info","message":"Creating PR with title: \"[7.x] [APM] Break down transaction table api removing the sparklines (#88946)\". kibanamachine:backport/7.x/pr-88946 -> 7.x"}
{"level":"info","message":"POST /repos/elastic/kibana/pulls - 201 in 1491ms"}
{"level":"info","message":"Adding assignees to #91284: cauemarcondes"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/91284/assignees - 201 in 1116ms"}
{"level":"info","message":"Adding labels: backport"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/91284/labels - 200 in 401ms"}
View pull request: https://github.com/elastic/kibana/pull/91284