Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decorateSnapshotUi: get file from stacktrace #88950

Merged
merged 5 commits into from
Jan 21, 2021

Conversation

dgieselaar
Copy link
Member

Instead of using test.file, use callsites() to get the test file from the stack trace. test.file is not always reliable.

Instead of using test.file, use callsites() to get the test file from the stack trace. test.file is not always reliable.
@dgieselaar dgieselaar added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 21, 2021
@dgieselaar dgieselaar requested a review from a team as a code owner January 21, 2021 11:24
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.9MB 1.9MB +21.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 60.1KB 60.1KB +21.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit fde4085 into elastic:master Jan 21, 2021
@dgieselaar dgieselaar deleted the get-file-from-stacktrace branch January 21, 2021 17:16
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants