Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.11] [Fleet]: ignore 404, check if there are transforms in results. (#80721) #88967

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

pzl
Copy link
Member

@pzl pzl commented Jan 21, 2021

Backport of #80721 into 7.11

This is a moderately old PR, that was backported to 7.10 in the day, but was not backported to 7.x, so when 7.11 was created, it also lacked this.

This is an important fix for two reported 7.11 bugs: #88630 and #88249

@pzl pzl added the backport label Jan 21, 2021
@pzl pzl requested review from kevinlog and a team January 21, 2021 13:41
@skh
Copy link
Contributor

skh commented Jan 21, 2021

What about those lines from the original PR, did they make it into 7.x some other way?

https://github.com/elastic/kibana/pull/80721/files#diff-b40ad176fe9b892e2f866f7b83ce8630fd96a9fc55f75e3f6e701d01098e1726R51-R61

@pzl
Copy link
Member Author

pzl commented Jan 21, 2021

What about those lines from the original PR, did they make it into 7.x some other way?

Yes, it looks like the if + for there seemed to make it into 7.11 some other way

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@skh skh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need codeowners' approval on backports, but here's one anyway.

@pzl pzl merged commit e6d73e7 into elastic:7.11 Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants