[ML] Fix swim lane time selection with a single time point and the Watcher URL #89125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
bug
|
Pinging @elastic/ml-ui (:ml) |
|
@elasticmachine merge upstream |
darnautov
changed the title
|
@elasticmachine merge upstream |
peteharverson
approved these changes
Jan 25, 2021
walterra
approved these changes
Jan 26, 2021
peteharverson
approved these changes
Jan 26, 2021
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jan 26, 2021
…tcher URL (elastic#89125) * [ML] fix swim lane selected times with only start boundaries * [ML] unit test * [ML] update url variables * [ML] selectedLanes to an array type * [ML] handle legacy query params
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jan 26, 2021
…tcher URL (elastic#89125) * [ML] fix swim lane selected times with only start boundaries * [ML] unit test * [ML] update url variables * [ML] selectedLanes to an array type * [ML] handle legacy query params
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jan 26, 2021
…tcher URL (elastic#89125) * [ML] fix swim lane selected times with only start boundaries * [ML] unit test * [ML] update url variables * [ML] selectedLanes to an array type * [ML] handle legacy query params # Conflicts: # x-pack/plugins/ml/public/application/jobs/jobs_list/components/create_watch_flyout/email.html
darnautov
added a commit
that referenced
this pull request
Jan 27, 2021
…tcher URL (#89125) (#89326) * [ML] fix swim lane selected times with only start boundaries * [ML] unit test * [ML] update url variables * [ML] selectedLanes to an array type * [ML] handle legacy query params # Conflicts: # x-pack/plugins/ml/public/application/jobs/jobs_list/components/create_watch_flyout/email.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During interaction with anomaly swim lane, cell selection always updates the URL state with appropriate time boundaries. But the watcher URL in the email template populate a single time point only. This PR fixes this scenario by extending the selection with a bucket span size. It also fixes the names of the URL variables used in the Watcher email template.
Checklist