Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrates license_management to a TS project ref #89472

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Migrates license_management to a TS project ref #89472

merged 2 commits into from
Jan 28, 2021

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Jan 27, 2021 •
edited
Loading

Summary

Partially resolves #89321

tsc compiler performance with running node --max-old-space-size=4096 ./node_modules/.bin/tsc -p x-pack/tsconfig.json --extendedDiagnostics --noEmit

** Before
Files: 16921
Lines: 1861400

** After
Files:
Lines:

@TinaHeiligers TinaHeiligers added chore v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 27, 2021
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner January 27, 2021 19:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@TinaHeiligers TinaHeiligers marked this pull request as draft January 27, 2021 19:27
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers marked this pull request as ready for review January 27, 2021 22:17
sebelga
sebelga approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this @TinaHeiligers !

@TinaHeiligers TinaHeiligers merged commit 681b239 into elastic:master Jan 28, 2021
@TinaHeiligers TinaHeiligers deleted the ts-project-refs-es_ui/license_management branch January 28, 2021 14:39
This was referenced Jan 28, 2021
Merged
Closed
Closed
TinaHeiligers added a commit that referenced this pull request Jan 28, 2021
@TinaHeiligers
[7.x] Migrates license_management to a TS project ref (#89472) (#89569)
3f57354
@TinaHeiligers TinaHeiligers mentioned this pull request Jan 30, 2021
Closed
@peteharverson peteharverson mentioned this pull request Feb 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

Assignees
No one assigned
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Meta] Migrate plugins to TS references for es_ui CODEOWNERS plugins
4 participants
@TinaHeiligers @elasticmachine @kibanamachine @sebelga